Open the "discard changes" dialog in the off-canvas tray

Attached is a fix which opens both discard changes and revert to defaults in a dialog.

I added an extra patch for people who use gin/gin layout builder, which ensures the buttons are rendered nicely.

The patch works as expected.

But can we do the width of the modal different? I looked up in Drupal core and mostly 880 px is used.
The FieldUiLocalAction is using 85vw which seems much better to implement then hard pixels?

The normal patch is probably what is needed and a follow up ticket will be needed in Gin Layout Builder to cover the classes on the button?

Still small nitpick:

+++ b/core/modules/layout_builder/src/Form/OverridesEntityForm.php
@@ -193,21 +194,27 @@ protected function actions(array $form, FormStateInterface $form_state) {
+    $actions ['discard_changes'] = [
...
+    $actions ['revert'] = [

There must be no space before the bracket.

The patch from #7 no longer applies, but I think this would be a sensible UX enhancement. I have pushed an issue fork and attached a patch for gin_lb users.

Looks like MR ready to review!
Dear Colleagues please you take a look.
Thanks

I've prepared some proof that MR does work. I used clean installation Drupal 11.

thanks

Hi,
I've reviewed the MR !9183 on Drupal 11.x.

Layout Discard changes opened in the dialog box.

Just checking issue summary it appears to be incomplete, UI changes should be placed

Left some comments on the MR

If they’re new functions being added type hints should be included. Unless it’s a base method that would require updating all spots.

Hi @smustgrave!
Could you provide a couple examples or give me direction, where i can have a look and read about

type hints should be included

I didn't clear understand your message.

Thank you.

Reviewed latest MR ,it applies cleanly and MR resolves mentioned issue.

Drupal version 11.x-dev

1. Create a layout with the Layout Builder.
2. Click on the "Discard changes" button in the Layout Builder.
3. Before MR, it would redirect to /node/[nid]/layout/discard-changes to confirm the dialog
4. After applying MR is opens in dialogue box.
5. Attaching screenshot for before and after.
Issue can be moved forward.
RTBC +

Feedback from #20 appears addressed

I've attached the gin-lb version patch for d10.3:

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

smustgrave → changed the visibility of the branch 11.x to hidden.

smustgrave → changed the visibility of the branch drupal-3223022-3223022-modal-discard-dialog to hidden.

Rebased but hiding the patch as that triggered the bot.

Hi gays,

i'de like to ask what we decided about patch?
Do we need more extra tests or works?

it would be my pleasure to help with this one.

thanks

sounds like a good idea. there is a merge conflict to resolve first

Rebased

Has another merge conflict - didn't actually review the change yet.

dcam → changed the visibility of the branch 3223022-modal-discard-dialog to hidden.

I don't know what's wrong with MR 9183. GitLab reports that it can't be rebased onto 11.x, but it clearly can. It just seems to be broken. I wondered if applying the changes to another branch would work. So I exported them to a patch and opened MR 11723. GitLab doesn't have any problem with it.

Restoring RTBC status.

Tagging this for needs usability review, the issue summary could use an update to indicate why this change is being made.