- Issue created by @rkoller
- 🇮🇳India sandip
While investigating the issue, I finds out the css is coming from
core/assets/vendor/jquery.ui/themes/base/dialog.css
. There is nodialog.css
in olivero so i think it would be better to create a library for dialog in olivero, similar to how it is handled in the Claro theme. So should i create the library in the Olivero?The truncating issue would be fixed by removing the
text-overflow: elipsis
andwhite-space: no-wrap
from h1 tag. This style is coming fromcore/assets/vendor/jquery.ui/themes/base/dialog.css
. - 🇩🇪Germany rkoller Nürnberg, Germany
oh interesting, thanks for investigating! i am not a developer therefore i dont feel qualified to make a recommendations about the approach how to fix a certain problem :/ the only thing i can say, it at least sounds reasonable staying consistent and choose the same approach claro uses.
- 🇮🇳India sandip
@rkoller, Thanks for the reply. So I am raising a MR with the approach I mentioned above within tomorrow so it would be great to review then.
- Merge request !12517Issue #3530198: The title of a dialog modal is getting truncated in Olivero → (Open) created by Unnamed author
- 🇮🇳India sandip
Actually, I didn’t need to create a new library as the necessary one is already present, but I missed it yesterday. The truncation issue is now resolved. However, the width of the dialog modal is set to 300px, and at that width, it's not possible to keep the heading on a single line. As a result, the heading is wrapping onto two lines. Could you please review it and let me know if it needs any changes.