- Issue created by @man-1982
- Assigned to man-1982
- Status changed to Needs review
11 months ago 7:17am 22 December 2023 - π¨π¦Canada man-1982
This patch aims to enhance the daterange_compact module by ensuring that its configuration pages are accessible and function correctly. It also adds a layer of automated testing for future development and maintenance.
Please review the attached patch and provide any feedback or additional testing from the community.
Added daterange_compact.routing.yml and Functional Test DateRangeCompactRoutingTest.php
Patch #3 worked for me; however, it is missing an "Add" button on the config page, so I had to edit an existing format for this to work. I was able to manually get to the add page, but could not save the new pattern.
- Status changed to Postponed: needs info
3 months ago 6:13pm 23 August 2024 - πΈπͺSweden erik.erskine
The entity type definition includes a
route_provider
property, which provides routes for add/edit/delete forms plus the collection. They are very similar to what's in this patch.There is no canonical route, but that's true of core's
date_format
config entities too.I don't see why a
routing.yml
file is needed.This patch aims to enhance the daterange_compact module by ensuring that its configuration pages are accessible and function correctly.
Are they not? Maybe I've misunderstood - if so, please reopen this.
- Status changed to Needs work
2 months ago 12:09am 6 September 2024 - π¨π¦Canada man-1982
we have daterange_compact.links.menu.yml:
entity.daterange_compact_format.collection: title: 'Compact date and time range formats' route_name: entity.daterange_compact_format.collection description: 'Configure how date and time ranges are displayed in a compact form.' parent: system.admin_config_regional weight: 0
it's mean that we expect in url /admin/config/regional/daterange-compact-format (=entity.daterange_compact_format.collection) entities list collection
instead we have "Page not found"
I attached a couple screenshot to be more clarified.
- Status changed to Needs review
2 months ago 1:00am 6 September 2024 - π¨π¦Canada man-1982
@erik.erskine
Sorry, I double-checked. You are right. There is no need extra router files.
I've made some changes in MR:- Added configure route
- Added some simple functional tests
Thanks
- Status changed to RTBC
2 months ago 1:02am 6 September 2024