- Issue created by @joachim
- Merge request !216Issue #3508681: Drupal\search_api\Annotation\SearchApiDisplay is missing... โ (Open) created by sorabh.v6
- ๐ฎ๐ณIndia sorabh.v6 Indore
Code pushed to the MR, moving task to "Needs review".
- ๐ฆ๐นAustria drunken monkey Vienna, Austria
Thanks for creating an MR, but I donโt think this is actually a bug. The annotation itself is for any search display, while those properties are specific to Views displays. I donโt think it makes sense to add those properties to the general-purpose
@SearchApiDisplay
annotation.
Is there any actual problem caused by this? - ๐ฌ๐งUnited Kingdom joachim
Views displays are the majority use case of search API displays, surely. Even if there are properties which aren't used in all cases, they should still be documented.
Without this documentation, it's harder for developers to figure out how to correctly declare a custom Views display type to SearchAPI.
- ๐ฎ๐ณIndia sorabh.v6 Indore
PR is ready for review and I am ready for feedback. :)