- Issue created by @yasminOrj
- Merge request !75Issue #3259348 by paulocs, joelpittet, beatrizrodrigues, lhridley: Remove... → (Open) created by chhavi.sharma
- 🇮🇳India chhavi.sharma
chhavi.sharma → changed the visibility of the branch 3492335-coding-standard-issues to hidden.
- 🇵🇭Philippines clarkssquared
Hi
I applied the updated MR !76, and I can still see many PHPCS errors and warning, there are so many issues being reported.
➜ ctools git:(4.1.x) curl https://git.drupalcode.org/project/ctools/-/merge_requests/76.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 54150 0 54150 0 0 99322 0 --:--:-- --:--:-- --:--:-- 98k patching file ctools.post_update.php patching file 'modules/ctools_entity_mask/src/MaskContentEntityStorage.php' patching file 'modules/ctools_views/src/Plugin/Display/Block.php' patching file 'src/ConstraintConditionInterface.php' patching file 'src/ContextNotFoundException.php' patching file 'src/Form/ManageContext.php' patching file 'src/Form/RequiredContext.php' patching file 'src/Plugin/Block/EntityView.php' patching file 'src/Plugin/BlockPluginCollection.php' patching file 'src/Plugin/BlockVariantTrait.php' patching file 'src/Plugin/Condition/EntityBundle.php' patching file 'src/Plugin/Condition/NodeType.php' patching file 'src/Plugin/Deriver/EntityBundle.php' patching file 'src/Plugin/Deriver/TypedDataEntityRelationshipDeriver.php' patching file 'src/Plugin/Deriver/TypedDataLanguageRelationshipDeriver.php' patching file 'src/Plugin/Deriver/TypedDataPropertyDeriverBase.php' patching file 'src/Plugin/Deriver/TypedDataRelationshipDeriver.php' patching file 'src/Plugin/Relationship/TypedDataEntityRelationship.php' patching file 'src/Plugin/Relationship/TypedDataLanguageRelationship.php' patching file 'src/Plugin/Relationship/TypedDataRelationship.php' patching file 'src/Plugin/RelationshipBase.php' patching file 'src/Plugin/RelationshipInterface.php' patching file 'src/Plugin/VariantCollectionTrait.php' patching file 'src/Plugin/VariantPluginCollection.php' patching file 'src/SerializableTempstore.php' patching file 'src/SerializableTempstoreFactory.php' patching file 'src/Testing/EntityCreationTrait.php' patching file 'src/TypedDataResolver.php' patching file 'src/Wizard/EntityFormWizardBase.php' patching file 'src/Wizard/EntityFormWizardInterface.php' patching file 'src/Wizard/FormWizardBase.php' patching file 'src/Wizard/FormWizardInterface.php' patching file 'tests/modules/ctools_block_display_test/src/Plugin/DisplayVariant/BlockDisplayVariant.php' patching file 'tests/modules/ctools_wizard_test/src/Entity/ExampleConfigEntity.php' patching file 'tests/modules/ctools_wizard_test/src/ExampleConfigEntityInterface.php' patching file 'tests/modules/ctools_wizard_test/src/ExampleConfigEntityListBuilder.php' patching file 'tests/modules/ctools_wizard_test/src/Wizard/EntityAddWizard.php' patching file 'tests/modules/ctools_wizard_test/src/Wizard/EntityEditWizard.php' patching file 'tests/modules/ctools_wizard_test/src/Wizard/EntityWizard.php' patching file 'tests/src/Functional/CToolsWizardTest.php' patching file 'tests/src/Kernel/RelationshipsTestBase.php' patching file 'tests/src/Kernel/TypedDataResolverTest.php' patching file 'tests/src/Unit/BlockDisplayVariantTest.php' patching file 'tests/src/Unit/BlockPluginCollectionTest.php' patching file 'tests/src/Unit/BlockVariantTraitTest.php' patching file 'tests/src/Unit/ContextMapperTest.php' patching file 'tests/src/Unit/VariantCollectionTraitTest.php' ➜ ctools git:(4.1.x) ✗ .. ➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ctools FILE: ...ontrib/ctools/tests/modules/ctools_wizard_test/ctools_wizard_test.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------------- FILE: ...rib/ctools/tests/modules/ctools_wizard_test/ctools_wizard_test.routing.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------- 9 | WARNING | Open page callback found, please add a comment before the line | | why there is no access restriction 18 | WARNING | Open page callback found, please add a comment before the line | | why there is no access restriction -------------------------------------------------------------------------------- FILE: ...sts/modules/ctools_wizard_test/src/Form/ExampleConfigEntityGeneralForm.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 26 | WARNING | Unused variable $config_entity. -------------------------------------------------------------------------------- FILE: ...tests/modules/ctools_block_display_test/ctools_block_display_test.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------------- FILE: ...t/web/modules/contrib/ctools/tests/src/Unit/VariantCollectionTraitTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Plugin\PluginManagerInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...al-project/web/modules/contrib/ctools/tests/src/Unit/ContextMapperTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\DependencyInjection\ContainerBuilder. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ject/web/modules/contrib/ctools/tests/src/Unit/BlockDisplayVariantTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Uuid\UuidInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...roject/web/modules/contrib/ctools/tests/src/Unit/BlockVariantTraitTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Uuid\UuidInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ct/web/modules/contrib/ctools/tests/src/Unit/BlockPluginCollectionTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Block\BlockManagerInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ject/web/modules/contrib/ctools/tests/src/Kernel/RelationshipsTestBase.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 61 | WARNING | Unused variable $article. -------------------------------------------------------------------------------- FILE: ...ct/web/modules/contrib/ctools/tests/src/Kernel/BlockDisplayVariantTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\ctools\Event\BlockVariantEvent. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ects/drupal-issues/drupal-project/web/modules/contrib/ctools/ctools.module -------------------------------------------------------------------------------- FOUND 15 ERRORS AND 5 WARNINGS AFFECTING 8 LINES -------------------------------------------------------------------------------- 17 | WARNING | Hook implementations should not duplicate @param documentation 17 | ERROR | Missing parameter comment 17 | ERROR | Missing parameter type 18 | WARNING | Hook implementations should not duplicate @param documentation 18 | ERROR | Missing parameter comment 18 | ERROR | Missing parameter type 19 | WARNING | Hook implementations should not duplicate @param documentation 19 | ERROR | Missing parameter comment 19 | ERROR | Missing parameter type 20 | WARNING | Hook implementations should not duplicate @param documentation 20 | ERROR | Missing parameter comment 20 | ERROR | Missing parameter type 22 | WARNING | Hook implementations should not duplicate @return documentation 22 | ERROR | Description for the @return value is missing 50 | ERROR | Missing parameter comment 50 | ERROR | Missing parameter type 67 | ERROR | Missing parameter comment 67 | ERROR | Missing parameter type 90 | ERROR | Missing parameter comment 90 | ERROR | Missing parameter type -------------------------------------------------------------------------------- FILE: ...Projects/drupal-issues/drupal-project/web/modules/contrib/ctools/README.md -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 86 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...odules/ctools_views/tests/src/Functional/CToolsViewsBasicViewBlockTest.php -------------------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES -------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is | | Drupal\Core\StringTranslation\StringTranslationTrait. 24 | ERROR | [ ] The @var tag must be the first tag in a member variable | | comment 26 | ERROR | [ ] Do not disable strict config schema checking in tests. | | Instead ensure your module properly declares its schema for | | configurations. 80 | WARNING | [ ] Unused variable $result. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...dules/ctools_views/tests/src/Functional/CToolsViewsEntityViewBlockTest.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES -------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\taxonomy\Entity\Vocabulary. 83 | ERROR | [ ] Do not disable strict config schema checking in tests. | | Instead ensure your module properly declares its schema | | for configurations. 183 | WARNING | [ ] Unused variable $default_theme. 275 | WARNING | [ ] Unused variable $default_theme. 277 | WARNING | [ ] Unused variable $filter_op_id. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...roject/web/modules/contrib/ctools/modules/ctools_views/ctools_views.module -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\ctools_views\Plugin\Display\Block. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...b/modules/contrib/ctools/modules/ctools_views/src/Plugin/Display/Block.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES -------------------------------------------------------------------------------- 284 | WARNING | Unused variable $identifier. 309 | WARNING | Line exceeds 80 characters; contains 81 characters 365 | WARNING | Unused variable $exposed_info. 758 | WARNING | Unused variable $id. -------------------------------------------------------------------------------- FILE: ...ock/tests/modules/ctools_block_field_test/ctools_block_field_test.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------------- FILE: ...tools_entity_mask/tests/modules/entity_mask_test/entity_mask_test.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | "Description" property is missing in the info.yml file -------------------------------------------------------------------------------- FILE: ...rib/ctools/modules/ctools_entity_mask/tests/src/Functional/DisplayTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------- 13 | WARNING | The class short comment should describe what the class does and | | not simply repeat the class name 87 | ERROR | unserialize() is insecure unless allowed classes are limited. | | Use a safe format like JSON or use the allowed_classes option. -------------------------------------------------------------------------------- FILE: ...trib/ctools/modules/ctools_entity_mask/tests/src/Kernel/EntityMaskTest.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 130 | ERROR | Public method name "EntityMaskTest::testNotExposedToFieldUI" is | | not in lowerCamel format 156 | ERROR | unserialize() is insecure unless allowed classes are limited. | | Use a safe format like JSON or use the allowed_classes option. -------------------------------------------------------------------------------- FILE: ...upal-project/web/modules/contrib/ctools/src/Form/RelationshipConfigure.php -------------------------------------------------------------------------------- FOUND 7 ERRORS AFFECTING 7 LINES -------------------------------------------------------------------------------- 11 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory. 39 | ERROR | [ ] Class property $tempstore_id should use lowerCamel naming | | without underscores 46 | ERROR | [ ] Class property $machine_name should use lowerCamel naming | | without underscores 151 | ERROR | [ ] Return type "array In the format of" must not contain spaces 161 | ERROR | [ ] Missing parameter comment 163 | ERROR | [ ] Parameter tags must be grouped together in a doc comment 177 | ERROR | [ ] Description for the @return value is missing -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...upal-project/web/modules/contrib/ctools/src/Form/RequiredContextDelete.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...project/web/modules/contrib/ctools/src/Form/ResolverRelationshipDelete.php -------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES -------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory. 36 | ERROR | [ ] Class property $tempstore_id should use lowerCamel naming | | without underscores 43 | ERROR | [ ] Class property $machine_name should use lowerCamel naming | | without underscores 133 | ERROR | [ ] Missing parameter type -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ject/web/modules/contrib/ctools/src/Form/ResolverRelationshipConfigure.php -------------------------------------------------------------------------------- FOUND 14 ERRORS AND 2 WARNINGS AFFECTING 12 LINES -------------------------------------------------------------------------------- 19 | ERROR | Missing short description in doc comment 24 | ERROR | Missing short description in doc comment 27 | ERROR | Class property $tempstore_id should use lowerCamel naming | | without underscores 29 | ERROR | Missing short description in doc comment 32 | ERROR | Class property $machine_name should use lowerCamel naming | | without underscores 126 | WARNING | Unused variable $id. 181 | ERROR | Missing parameter comment 181 | ERROR | Missing parameter type 185 | WARNING | Line exceeds 80 characters; contains 92 characters 192 | ERROR | Missing parameter comment 192 | ERROR | Missing parameter type 194 | ERROR | Description for the @return value is missing 201 | ERROR | Missing parameter comment 201 | ERROR | Missing parameter type 203 | ERROR | Parameter tags must be grouped together in a doc comment 203 | ERROR | Missing parameter type -------------------------------------------------------------------------------- FILE: ...ssues/drupal-project/web/modules/contrib/ctools/src/Form/ContextDelete.php -------------------------------------------------------------------------------- FOUND 7 ERRORS AFFECTING 7 LINES -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Form\ConfirmFormBase. 15 | ERROR | [ ] Missing short description in doc comment 20 | ERROR | [ ] Missing short description in doc comment 23 | ERROR | [ ] Class property $tempstore_id should use lowerCamel naming | | without underscores 25 | ERROR | [ ] Missing short description in doc comment 28 | ERROR | [ ] Class property $machine_name should use lowerCamel naming | | without underscores 35 | ERROR | [ ] Class property $context_id should use lowerCamel naming | | without underscores -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...es/drupal-project/web/modules/contrib/ctools/src/Form/ContextConfigure.php -------------------------------------------------------------------------------- FOUND 12 ERRORS AND 2 WARNINGS AFFECTING 11 LINES -------------------------------------------------------------------------------- 43 | ERROR | Class property $tempstore_id should use lowerCamel naming | | without underscores 50 | ERROR | Class property $machine_name should use lowerCamel naming | | without underscores 172 | WARNING | Line exceeds 80 characters; contains 107 characters 246 | ERROR | Missing parameter comment 246 | ERROR | Missing parameter type 250 | WARNING | Line exceeds 80 characters; contains 92 characters 257 | ERROR | Missing parameter comment 257 | ERROR | Missing parameter type 259 | ERROR | Description for the @return value is missing 283 | ERROR | Missing parameter type 293 | ERROR | Parameter $machine_name is not described in comment 296 | ERROR | Missing parameter comment 296 | ERROR | Missing parameter type 298 | ERROR | Description for the @return value is missing -------------------------------------------------------------------------------- FILE: ...ues/drupal-project/web/modules/contrib/ctools/src/Form/ConditionDelete.php -------------------------------------------------------------------------------- FOUND 11 ERRORS AND 1 WARNING AFFECTING 12 LINES -------------------------------------------------------------------------------- 11 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory. 19 | ERROR | [ ] Missing short description in doc comment 24 | ERROR | [ ] Missing short description in doc comment 29 | ERROR | [ ] Missing short description in doc comment 32 | ERROR | [ ] Class property $tempstore_id should use lowerCamel naming | | without underscores 34 | ERROR | [ ] Missing short description in doc comment 37 | ERROR | [ ] Class property $machine_name should use lowerCamel naming | | without underscores 39 | ERROR | [ ] Missing short description in doc comment 116 | ERROR | [ ] Missing parameter type 118 | ERROR | [ ] Missing parameter type 198 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters 232 | ERROR | [ ] Description for the @return value is missing -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...es/drupal-project/web/modules/contrib/ctools/src/Form/ManageConditions.php -------------------------------------------------------------------------------- FOUND 28 ERRORS AND 1 WARNING AFFECTING 24 LINES -------------------------------------------------------------------------------- 15 | ERROR | Doc comment is empty 20 | ERROR | Missing short description in doc comment 32 | ERROR | Missing short description in doc comment 35 | ERROR | Class property $machine_name should use lowerCamel naming | | without underscores 37 | ERROR | Doc comment is empty 47 | ERROR | Doc comment is empty 111 | ERROR | Doc comment is empty 133 | ERROR | Missing short description in doc comment 134 | ERROR | Missing parameter comment 134 | ERROR | Missing parameter type 136 | ERROR | Description for the @return value is missing 151 | ERROR | Key specified for array entry; first entry has no key 159 | ERROR | Doc comment is empty 197 | ERROR | Description for the @return value is missing 204 | ERROR | Missing parameter comment 206 | ERROR | Description for the @return value is missing 213 | ERROR | Description for the @return value is missing 226 | ERROR | Missing parameter comment 228 | ERROR | Parameter tags must be grouped together in a doc comment 228 | ERROR | Missing parameter comment 230 | ERROR | Parameter tags must be grouped together in a doc comment 230 | ERROR | Missing parameter comment 234 | WARNING | Line exceeds 80 characters; contains 88 characters 241 | ERROR | Missing parameter comment 241 | ERROR | Missing parameter type 243 | ERROR | Description for the @return value is missing 250 | ERROR | Missing parameter comment 250 | ERROR | Missing parameter type 252 | ERROR | Description for the @return value is missing -------------------------------------------------------------------------------- FILE: ...ues/drupal-project/web/modules/contrib/ctools/src/Form/RequiredContext.php -------------------------------------------------------------------------------- FOUND 11 ERRORS AND 1 WARNING AFFECTING 12 LINES -------------------------------------------------------------------------------- 12 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Form\FormBuilderInterface. 19 | ERROR | [ ] Missing short description in doc comment 31 | ERROR | [ ] Missing short description in doc comment 34 | ERROR | [ ] Class property $machine_name should use lowerCamel naming | | without underscores 117 | ERROR | [ ] Missing parameter comment 118 | ERROR | [ ] Missing parameter comment 120 | ERROR | [ ] Description for the @return value is missing 134 | ERROR | [ ] Missing parameter type 143 | WARNING | [ ] Unused variable $machine_name. 150 | ERROR | [ ] The array declaration extends to column 129 (the limit is | | 120). The array content should be split up over multiple | | lines 152 | ERROR | [ ] Key specified for array entry; first entry has no key 163 | ERROR | [ ] Missing parameter type -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ssues/drupal-project/web/modules/contrib/ctools/src/Form/ManageContext.php -------------------------------------------------------------------------------- FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES -------------------------------------------------------------------------------- 26 | ERROR | Class property $machine_name should use lowerCamel naming | | without underscores 54 | ERROR | Class property $property_types should use lowerCamel naming | | without underscores 119 | WARNING | Variable $types inside unset call is undefined. 273 | ERROR | Key specified for array entry; first entry has no key 426 | ERROR | Missing short description in doc comment -------------------------------------------------------------------------------- FILE: .../drupal-project/web/modules/contrib/ctools/src/Form/ConditionConfigure.php -------------------------------------------------------------------------------- FOUND 8 ERRORS AFFECTING 8 LINES -------------------------------------------------------------------------------- 14 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory. 23 | ERROR | [ ] Missing short description in doc comment 28 | ERROR | [ ] Missing short description in doc comment 33 | ERROR | [ ] Missing short description in doc comment 36 | ERROR | [ ] Class property $tempstore_id should use lowerCamel naming | | without underscores 38 | ERROR | [ ] Missing short description in doc comment 41 | ERROR | [ ] Class property $machine_name should use lowerCamel naming | | without underscores 190 | ERROR | [ ] Parameter tags must be grouped together in a doc comment -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...roject/web/modules/contrib/ctools/src/Form/ManageResolverRelationships.php -------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------- 25 | ERROR | Class property $machine_name should use lowerCamel naming | | without underscores 32 | ERROR | Class property $property_types should use lowerCamel naming | | without underscores 187 | ERROR | Key specified for array entry; first entry has no key -------------------------------------------------------------------------------- FILE: ...al-project/web/modules/contrib/ctools/src/SerializableTempstoreFactory.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\TempStore\SharedTempStore. 11 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately | | following it -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...s/drupal-project/web/modules/contrib/ctools/src/Access/TempstoreAccess.php -------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES -------------------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory. 42 | ERROR | [ ] Missing parameter comment 43 | ERROR | [ ] Missing parameter comment 44 | ERROR | [ ] Missing parameter comment 46 | ERROR | [ ] Description for the @return value is missing -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...oject/web/modules/contrib/ctools/src/ParamConverter/TempstoreConverter.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 96 | ERROR | Parameter $entity_type_manager is not described in comment 99 | ERROR | Missing parameter comment -------------------------------------------------------------------------------- FILE: ...b/modules/contrib/ctools/src/Plugin/DisplayVariant/BlockDisplayVariant.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Display\ContextAwareVariantInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...upal-project/web/modules/contrib/ctools/src/Plugin/RelationshipManager.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Cache\CacheBackendInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...-project/web/modules/contrib/ctools/src/Plugin/VariantPluginCollection.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 18 | WARNING | Possible useless method overriding detected -------------------------------------------------------------------------------- FILE: ...rupal-project/web/modules/contrib/ctools/src/Plugin/Condition/NodeType.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 17 | ERROR | Missing short description in doc comment -------------------------------------------------------------------------------- FILE: ...l-project/web/modules/contrib/ctools/src/Plugin/Condition/EntityBundle.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------- 26 | WARNING | Unused variable $definition_id. 39 | WARNING | Unused variable $definition_id. -------------------------------------------------------------------------------- FILE: ...modules/contrib/ctools/src/Plugin/Deriver/TypedDataRelationshipDeriver.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------- 36 | WARNING | Only string literals should be passed to t() where possible 79 | WARNING | Only string literals should be passed to t() where possible -------------------------------------------------------------------------------- FILE: ...pal-project/web/modules/contrib/ctools/src/Plugin/Deriver/EntityBundle.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 10 | ERROR | Each @deprecated tag must have a @see tag immediately following | | it -------------------------------------------------------------------------------- FILE: ...roject/web/modules/contrib/ctools/src/Plugin/Deriver/EntityDeriverBase.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Entity\EntityFieldManagerInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...al-project/web/modules/contrib/ctools/src/Plugin/BlockPluginCollection.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 19 | WARNING | Possible useless method overriding detected -------------------------------------------------------------------------------- FILE: .../drupal-project/web/modules/contrib/ctools/src/Plugin/Block/EntityView.php -------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES -------------------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is | | Drupal\Core\Entity\EntityDisplayRepositoryInterface. 27 | ERROR | [ ] Missing member variable doc comment 106 | ERROR | [ ] Doc comment is empty 116 | ERROR | [ ] Doc comment is empty -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ues/drupal-project/web/modules/contrib/ctools/src/Wizard/WizardFactory.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Render\RendererInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...es/drupal-project/web/modules/contrib/ctools/src/Wizard/FormWizardBase.php -------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------- 17 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory. 59 | ERROR | [ ] Class property $tempstore_id should use lowerCamel naming | | without underscores 66 | ERROR | [ ] Class property $machine_name should use lowerCamel naming | | without underscores -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...pal-project/web/modules/contrib/ctools/src/Wizard/EntityFormWizardBase.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 12 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\TempStore\SharedTempStoreFactory. 45 | ERROR | [ ] Doc comment for parameter $tempstore_id does not match actual | | variable name $step -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...project/web/modules/contrib/ctools/src/Controller/WizardFormController.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 45 | ERROR | Missing short description in doc comment -------------------------------------------------------------------------------- FILE: ...t/web/modules/contrib/ctools/src/Controller/WizardEntityFormController.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 23 | ERROR | Missing short description in doc comment -------------------------------------------------------------------------------- FILE: ...pal-project/web/modules/contrib/ctools/src/Testing/EntityCreationTrait.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Render\FormattableMarkup. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...es/drupal-project/web/modules/contrib/ctools/src/SerializableTempstore.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 11 | ERROR | Each @deprecated tag must have a @see tag immediately following | | it -------------------------------------------------------------------------------- FILE: ...drupal-project/web/modules/contrib/ctools/src/ContextNotFoundException.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 8 | WARNING | Line exceeds 80 characters; contains 100 characters -------------------------------------------------------------------------------- FILE: ...issues/drupal-project/web/modules/contrib/ctools/src/Event/WizardEvent.php -------------------------------------------------------------------------------- FOUND 7 ERRORS AFFECTING 7 LINES -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\EventDispatcher\Event. 13 | ERROR | [ ] Missing short description in doc comment 18 | ERROR | [ ] Missing short description in doc comment 23 | ERROR | [ ] Doc comment is empty 31 | ERROR | [ ] Doc comment is empty 38 | ERROR | [ ] Doc comment is empty 45 | ERROR | [ ] Doc comment is empty -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: .../drupal-project/web/modules/contrib/ctools/src/Event/BlockVariantEvent.php -------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------- 9 | ERROR | Doc comment is empty 44 | ERROR | Description for the @return value is missing 53 | ERROR | Description for the @return value is missing -------------------------------------------------------------------------------- FILE: ...pal-project/web/modules/contrib/ctools/src/Ajax/OpenModalWizardCommand.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 7 | ERROR | Doc comment is empty 12 | ERROR | Doc comment is empty -------------------------------------------------------------------------------- Time: 2.48 secs; Memory: 18MB ➜ contrib git:(main) ✗ - Assigned to sorabh.v6
- Status changed to Needs work
about 2 months ago 7:28am 7 March 2025 - 🇨🇦Canada joelpittet Vancouver
Sorry these issues are too disruptive to bugs in the queue, don’t spend any time on code standards issues 🙏