Drupal 11.2 upgrade causes \Drupal::$container is not initialized yet error

lib/Drupal.php).
Drupal::getContainer() (Line: 414)
Drupal::config() (Line: 56)
include_once() (Line: 184)

This looks like the problem. It seems that you have some code somewhere that is calling \Drupal::config() when a file is included (outside a class or function context). If you can find out where that is, that will help a lot to track this down.

Enabling xdebug in ddev may help to get more backtrace information.

So I searched for \Drupal::config() inside all of modules and themes, found nothing. I'll see about xdebug for additional backtrace.

I'm seeing similar issues pop up accross a multitude of other modules like this:
https://www.drupal.org/project/launch_checklist/issues/3498288#comment-1... 🐛 "$container is not initialized yet" errors following upgrade to D11.1.0 Active

In that case the issue stemmed from:
include \Drupal::service('extension.list.module')->getPath('launch_checklist') . '/inc/routes.inc';

Granted, I am not using that particular module, but am seeing these issues out there.

I have the same problem. The only difference is that I am experiencing this problem with the field encrypt module. When I remove field encrypt, the problem goes away. When I activate it, I experience it again. Usually, with the Drush updb command...

@jnicola can you check for hook_module_implements_alter()

🐛 \Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container. Active looks similar-ish.

🐛 Kint breaks drush updb for Drupal CMS Active looks like the exact error you're getting.

Ah yep, Kint was indeed my issue. Disabling it has allowed me to proceed.

I do think it's worth noting and continuing to discuss here that some change between 11.0 and 11.1 is causing this issues for a bunch of contrib modules and breaking site upgrades for folks. It's also not terribly easy to troubleshoot with the current error output, even with backtrace. What changed in core that resulted in this sort of sensitivity across a variety of modules? Can anything be done to address this better and/or useful error output to inform module developers of their issue?

@pearls field_encrypt needs 📌 Migrate to OOP hooks Needs review and 📌 Support OOP hooks Active to be ready for 11.1.

@jnicola

bunch of contrib modules and breaking site upgrades for folks

So far I am aware of three modules that broke. It's helpful to identify them so we can help maintainers update!

It's also not terribly easy to troubleshoot with the current error output, even with backtrace

I agree, so far one only seen this with modules doing something in hook module implements alter.

Unfortunately for oop hooks we need to execute hmia but it happens at a time that a lot of things are not available. It is in the breaking changes section of the oop change record.
Most modules are doing something unnecessary and it's an easy fix. Field encrypt is an exception and harder to fix.

Fair fair, well, let's see what comes in as more folks run into this and troubleshoot it, and thanks for everyones time!

Also @jnicola, did you search for \Drupal::config() or \Drupal::config( it has an argument so if you searched the former the kint implementation would not show up but the latter would.

I wonder if it's worth putting something in the cr about calling services directly.

Can we improve the error messaging?

Could we try/catch the exception when executing hmia/including the modules and add the module name to the error message?

Or could we even eat the exception and trigger_error() instead?

The office_hours module suffered/suffers from this problem.
See
🐛 Drupal 11.1 Crash Active and follow up Child issues.

The module included 2 files from the .module files itself, after removing that, and including all books in the module file, a Follow up was encountered for a nested included. Removed that as well.
Now, the 2nd theming file is still not included, as reporter by a user.

The office_hours.module.file.now contains this one line, and the theme file seems not to be loaded.

// Include file, avoiding container error during upgrade.
if (\Drupal::hasContainer()) {
  // Add theme.api.php hooks.
  \Drupal::moduleHandler()->loadInclude('office_hours', 'inc', 'office_hours.theme');
}

@ghost of drupal past, can you explain the reasoning of your patch? Also, in my problem, I have theme hooks, not _alter() hooks.

Itis a wild guess, but Drupal 11.1 Adds Hooks as Classes mentions "In Drupal 11.1, the logic for calling a function based hook is now in ModuleHandler::legacyInvoke()".
So the introduction of that might be the culprit.
Anyway, this seems to be an error.

#17/#18 is a different issue as far as I can tell. I don't understand it but it's not the same issue, again, as far as I can see.

Re #18 Office hours should be including its own file directly, it knows where it is, and does not need to go via the container at all.

My #17/#18 was a response to #13, waiting for more (IIUC modules).
I think this problem is not module specific, since it is playing by the boom, until an upgrade to D11. 1 was performer.

I'll convert this to an MR later and add a test.

To recap what's happened: the original hook OOP patch was a half year effort (including me travelling to Burgas on my own money solely to get it done but I digress) and obviously went through a lot of revisions. Including every module seemed necessary to get tests pass. As the patch shows, by the current revision it's no longer necessary and can be disaggregated into separate includes. We just never went through this effort because it didn't seem necessary -- but of course it is. This change is also beneficial in that it allows removing the separate includes in the future as each legacy mechanism bites the dust:

• 📌 Investigate ModuleHandler::add Active , 📌 12.x Remove ModuleHandler::add and methods that use it. Active
• 📌 Hook ordering across OOP, procedural and with extra types Active
• 📌 Deprecate hook_hook_info() Active

Thanks @nicxvan MR/patches mentioned in #12 did not provide a solution. They are also not ready to be applied.

Yes they still need work.

I converted the patch to an MR. I could use some advice on the test, I tried a few different ways to trigger the failure before applying the patch, but nothing blew up. I added simple version of what I was doing for tests so people can check what I may be missing.

No need to write a new test, just stick a Drupal::getContainer() call into any module used by a functional test, just to the top of the module. If it doesn't blow up then that's good enough, comment it's the test for this issue and to move it to another module should that one get deleted for any reason and call it a day.

Thanks for your advice, got a test in!

Note, test only passes because the breaking change was introduced in config_test.module.

Not sure if this tag is appropriate, but someone needs to apply all the changes but the hook collector pass and module handler changes and confirm the test fails.

Core doesn't have any modules doing what contrib is doing so part of the test is introducing that pattern too.

Got some old test artifacts

I cleaned up, but I cannot get the test to fail, I created a new branch just to test it, but it is inconsistent.

Locally I could get it to fail if I installed the site and enabled config_test manually sometimes.
I could not get the test to fail.

I had a theory, something is different with core functional tests. It fails as expected in normal functional tests.

Is it enough to leave a comment on the .module file or do we need a dedicated failing test?

Have not reviewed yet but issue summary needs some attention.

Thanks.

nicxvan → changed the visibility of the branch 3505049-Failing-Testonly to hidden.

Ok I moved this to a new module and in a location where the test actually fails without the fix.

It seems there is something about functional tests in core not triggering this. I moved it to system, so this is ready for review.

I've updated the issue summary.

@jnicola, a minor request, when you create an issue, please leave all of the headings even if you do not need them at the moment, fill out the relevant ones. The other headings are needed and it saves someone needing to copy them over.

Ok for my own sanity:

git checkout 11.x
Switched to branch '11.x'
Your branch is up to date with 'origin/11.x'.
nic@computer:/var/www/development/drupal$ ddev unit core/modules/system/tests/src/Functional/Hook/HookCollectorPassTest.php
PHPUnit 10.5.38 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.10
Configuration: /var/www/html/phpunit.xml

F                                                                   1 / 1 (100%)

Time: 00:08.124, Memory: 4.00 MB

There was 1 failure:

1) Drupal\Tests\system\Functional\Hook\HookCollectorPassTest::testPreExistingConfigInstall
Behat\Mink\Exception\ExpectationException: The string "Module <em class="placeholder">Container call outside function</em> has been installed." was not found anywhere in the HTML response of the current page.

/var/www/html/vendor/behat/mink/src/WebAssert.php:888
/var/www/html/vendor/behat/mink/src/WebAssert.php:363
/var/www/html/core/tests/Drupal/Tests/WebAssert.php:558
/var/www/html/core/modules/system/tests/src/Functional/Hook/HookCollectorPassTest.php:55

You can see that fails the test on 11.x

I checkout this branch and revert the changes in HCP and module handler with git restore --source=b23f42703841a4632bce667dc58c16221d5e0998 core/lib
I confirmed that Drupal has the same code as HEAD
I run the test and it passes.

Your branch is up to date with 'drupal-3505049/3505049-drupal-11.1.2-upgrade'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   core/lib/Drupal/Core/Extension/ModuleHandler.php
        modified:   core/lib/Drupal/Core/Hook/HookCollectorPass.php

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        .gitignore

no changes added to commit (use "git add" and/or "git commit -a")
nic@weregiraffe:/var/www/development/drupal$ ddev unit core/modules/system/tests/src/Functional/Hook/HookCollectorPassTest.php
PHPUnit 10.5.38 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.10
Configuration: /var/www/html/phpunit.xml

.                                                                   1 / 1 (100%)

Time: 00:08.393, Memory: 4.00 MB

OK (1 test, 6 assertions)

Any insight would be appreciated.

It might be - try a ddev restart (or fpm etc. if not) or incrementing deployment_identifier?

I think I did run ddev start again, if it were a file cache wouldn't test only fail?

I ran into this issue just today when I updated from 10.4 to 11.1 as recommend. The Upgrade Status module gave the green light to update. Now, drush commands will not work. Tried all the usual things, clearing cache's etc.

I thought things were suppossed to become easier when updating Drupal? Now, there are several different roads to take, update to this version to get to that version that might work, even if a core supported module tells you it is good to go, it probably isn't , claims in documentation on how easy it is etc...

Well, it isn't easy what so ever. It is actually becoming increasingly diffcult to deal with. It is all fine when you're tinkering around. But, whe you have clients paying for this stuff it makes the developer look like an idiot. Not fun.

If things become worse I might just start recommending WIX!! haha!

drush updb -y

In Drupal.php line 169:

\Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container.

[townscanada@rockstar www]$ drush sqlq "TRUNCATE cache_config; TRUNCATE cache_container; TRUNCATE cache_data; TRUNCATE cache_default; TRUNCATE cache_discovery; TRUNCATE cache_dynamic_page_cache; TRUNCATE cache_entity; TRUNCATE cache_menu; TRUNCATE cache_render;"

[townscanada@rockstar www]$ drush cr

In Drupal.php line 169:

\Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container.

Did you test the fix in this issue?

I've had the same problem happening during drush updb that resulted in custom modules with functional split up files to throw the error when loading files via Drupal::moduleHandler()->loadInclude().

https://git.drupalcode.org/project/drupal/-/merge_requests/11169.patch fixed it for me so that I don't get an error while using drush updb anymore.

Hi Team @ nicxvan → , @ rudi teschner →

I still have no luck yet. Here for my issue, @ rudi teschner, how do you add the path to fix it? Any help, please. Thank you!

The website encountered an unexpected error. Try again later.
Drupal\Core\DependencyInjection\ContainerNotInitializedException: \Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container. in Drupal::getContainer() (line 169 of core/lib/Drupal.php).
Drupal::getContainer() (Line: 197)
Drupal::service() (Line: 101)
gin_lb_module_implements_alter() (Line: 94)
Drupal\Core\Hook\HookCollectorPass->process() (Line: 73)
Symfony\Component\DependencyInjection\Compiler\Compiler->compile() (Line: 814)
Symfony\Component\DependencyInjection\ContainerBuilder->compile() (Line: 1381)
Drupal\Core\DrupalKernel->compileContainer() (Line: 900)
Drupal\Core\DrupalKernel->initializeContainer() (Line: 505)
Drupal\Core\DrupalKernel->boot() (Line: 707)
Drupal\Core\DrupalKernel->handle() (Line: 19)

@smethawee I've added the patch to drupal/core in my project's composer.patches.json file
"3505049 - Drupal 11.1.2 upgrade causes \\Drupal::$container is not initialized yet error": "https://git.drupalcode.org/project/drupal/-/merge_requests/11169.patch"

and triggered drush cr afterwards. Result might be coincidence though since I didn't verify against a clean build.

The maintainers of the workflow module adressed this issue https://www.drupal.org/project/workflow/issues/3497950 🐛 \Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container. Active by changing the calls to loadInclude to require_once

- \Drupal::moduleHandler()->loadInclude('workflow', 'php', 'workflow.api');
+ require_once __DIR__ . '/../../workflow.api.php';

Hi @ rudi teschner → ,

Thank you for you to reply. This is the correct one on composer? I'm still no luck.

"drupal/tests": {
"3505049 - Drupal 11.1.2 upgrade causes \\Drupal::$container is not initialized yet error": "https://git.drupalcode.org/project/drupal/-/merge_requests/11169.patch"
}

@smethawee
In my composer.patches.json its not drupal/tests but drupal/core since composer would not know that it has to patch core otherwise, does it?

    "drupal/core":{
      "3505049 - Drupal 11.1.2 upgrade causes \\Drupal::$container is not initialized yet error": "https://git.drupalcode.org/project/drupal/-/merge_requests/11169.patch",
    },

Aside from that I fear I do not have any other useful suggestion

@rudi teschner,
I so wondering about this. Thank you for you helped. But I still get the issue when run drush any command > drush updb or drush cr please below:

Just to be clear, you should download the changes to a file and add that file to your repository in the patched directory.

You should not be using the MR diff directly for patching because anytime someone pushes a change your build will use the new change and you may not have tested it.

@ nicxvan,

Thank you nicxvan!!! But I don't know which file I have to download from the changes to a file and add that file to my repository in the patched directory, Where I can find the patched directory?... /docroot/core/modules/system/tests/modules?

@smethawee, I don't want to derail this discussion too much more, but you should basically do what was mentioned in #50, but instead of putting the link https://git.drupalcode.org/project/drupal/-/merge_requests/11169.patch copy the content of that page into a file and reference it. Feel free to reach out on slack if you have more questions.

That test was a doozy, this is ready for review though.

I think this might qualify as critical.

Hi there,
can anyone say why it fails?

patch -p1 -f < ../11169.patch
patching file core/modules/system/tests/modules/hook_collector_skip_procedural_attribute/hook_collector_skip_procedural_attribute.module
Hunk #1 succeeded at 12 with fuzz 2 (offset 3 lines).
The next patch would create the file core/tests/Drupal/FunctionalTests/Hook/HookCollectorPassTest.php,
which already exists! Applying it anyway.
patching file core/tests/Drupal/FunctionalTests/Hook/HookCollectorPassTest.php
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file core/tests/Drupal/FunctionalTests/Hook/HookCollectorPassTest.php.rej
patching file core/lib/Drupal/Core/Extension/ModuleHandler.php
Hunk #1 FAILED at 189.
1 out of 1 hunk FAILED -- saving rejects to file core/lib/Drupal/Core/Extension/ModuleHandler.php.rej
patching file core/lib/Drupal/Core/Hook/HookCollectorPass.php
Hunk #1 FAILED at 179.
Hunk #2 FAILED at 329.
2 out of 2 hunks FAILED -- saving rejects to file core/lib/Drupal/Core/Hook/HookCollectorPass.php.rej
The next patch would create the file core/modules/config/tests/config_test/config_test.module,
which already exists! Applying it anyway.
patching file core/modules/config/tests/config_test/config_test.module
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file core/modules/config/tests/config_test/config_test.module.rej
patching file core/tests/Drupal/FunctionalTests/Hook/HookCollectorPassTest.php
Hunk #1 FAILED at 14.
Hunk #2 FAILED at 24.
2 out of 2 hunks FAILED -- saving rejects to file core/tests/Drupal/FunctionalTests/Hook/HookCollectorPassTest.php.rej
patching file core/modules/config/tests/config_test/config_test.module
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file core/modules/config/tests/config_test/config_test.module.rej
patching file core/modules/config/tests/config_test/config_test.module
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file core/modules/config/tests/config_test/config_test.module.rej
patching file core/modules/system/tests/modules/hook_collector_skip_procedural_attribute/hook_collector_skip_procedural_attribute.module
Hunk #1 succeeded at 12 with fuzz 2 (offset 3 lines).
patching file core/tests/Drupal/FunctionalTests/Hook/HookCollectorPassTest.php
Hunk #1 FAILED at 43.
1 out of 1 hunk FAILED -- saving rejects to file core/tests/Drupal/FunctionalTests/Hook/HookCollectorPassTest.php.rej
patching file core/modules/system/tests/modules/container_no_function/container_no_function.info.yml
patching file core/modules/system/tests/modules/container_no_function/container_no_function.module (renamed from core/modules/config/tests/config_test/config_test.module)
patching file core/modules/system/tests/src/Functional/Hook/HookCollectorPassTest.php (renamed from core/tests/Drupal/FunctionalTests/Hook/HookCollectorPassTest.php)
Cannot rename file without two valid file names

Hello Guys,
I am running into an issue, While upgrading my Drupal Website from Drupal 10.4 to Drupal 11, I am running into an issue.
I am attaching the screenshot of issue, This occurs when i runs upgrade command.
It would be really appreciated if I can get some help over here.
And Thank You.

I ran into this issue when I upgraded from 11.1.4 to 11.1.5. I created a patch from the MR and it applied, but I still get the error.

Can you list your module's?

"require": {
"php": ">=7.4",
"civicrm/civicrm-asset-plugin": "~1.1",
"civicrm/civicrm-core": "^5.78",
"civicrm/civicrm-drupal-8": "^5.80",
"civicrm/civicrm-packages": "^5.80",
"civicrm/cli-tools": "^2024.09",
"composer/installers": "^1.9",
"cweagans/composer-patches": "^1.7",
"drupal/admin_toolbar": "^3.5",
"drupal/antibot": "^2.0",
"drupal/auto_translation": "^1.3",
"drupal/better_exposed_filters": "^7.0",
"drupal/book": "^2.0",
"drupal/calendar": "^1.0@beta",
"drupal/calendar_view": "^2.1",
"drupal/civicrm_drush": "^4.0@beta",
"drupal/civicrm_entity": "4.0.x-dev@dev",
"drupal/civicrm_entity_leaflet-civicrm_entity_leaflet": "^2.0@alpha",
"drupal/civicrm_reroute_mail": "^1.0",
"drupal/color": "^1.0",
"drupal/config_update": "^2.0@alpha",
"drupal/core": "11.0.12",
"drupal/core-composer-scaffold": "^11.0.12",
"drupal/core-recommended": "^11.0.12",
"drupal/drupal_slider": "^2.1",
"drupal/entity": "^1.5",
"drupal/entity_reference_revisions": "^1.12",
"drupal/features": "^5.0@alpha",
"drupal/forum": "^1.0",
"drupal/geocoder": "^4.26",
"drupal/geolocation": "^3.10",
"drupal/gin": "^4.0",
"drupal/gin_toolbar": "^2.0",
"drupal/hierarchical_taxonomy_menu": "^2.0",
"drupal/honeypot": "^2.2",
"drupal/imce": "^3.1",
"drupal/inline_entity_form": "^3.0@RC",
"drupal/jwt": "^2.2",
"drupal/leaflet": "^10.2",
"drupal/leaflet_more_maps": "^2.2",
"drupal/legal": "^4.0@alpha",
"drupal/mailchimp": "^3.0",
"drupal/maillog": "^1.1",
"drupal/mailsystem": "^4.5",
"drupal/masquerade": "^2.0",
"drupal/metatag": "^2.1",
"drupal/migrate_plus": "^6.0",
"drupal/migrate_upgrade": "^4.0",
"drupal/mimemail": "^1.0@alpha",
"drupal/passwordless": "2.0.x-dev@dev",
"drupal/pathauto": "^1.13",
"drupal/phpmailer_smtp": "2.2.x-dev@dev",
"drupal/profile": "^1.11",
"drupal/rdf": "^3.0@beta",
"drupal/recaptcha_v3": "^2.0",
"drupal/reroute_email": "^2.3@RC",
"drupal/slick": "^3.0",
"drupal/slick_views": "^3.0",
"drupal/smart_ip": "^5.0@alpha",
"drupal/smtp": "^1.0",
"drupal/state_machine": "^1.12",
"drupal/superfish": "^1.6",
"drupal/tiny_slider": "^1.1@RC",
"drupal/token": "^1.15",
"drupal/twig_tweak": "^3.3",
"drupal/upgrade_status": "^4.3",
"drupal/views_infinite_scroll": "^2.0",
"drupal/views_migration": "^1.2",
"drupal/views_slideshow": "^5.0",
"drupal/views_templates": "^1.2",
"drupal/webform": "^6.3@alpha",
"drupal/webform_civicrm": "^6.2",
"drupal/webform_migrate": "^2.0@alpha",
"drush/drush": "^13",
"mglaman/composer-drupal-lenient": "^1.0",
"phpoffice/phpword": "^1.2",
"vlucas/phpdotenv": "^5.1",
"webflo/drupal-finder": "^1.2",
"wikimedia/composer-merge-plugin": "^2.1"
},

I am currently at 11.0.12 version of Drupal.

Here are my modules:

"require": {
        "composer/installers": "^2.3",
        "drupal/admin_toolbar": "^3.5",
        "drupal/better_exposed_filters": "^7.0",
        "drupal/coffee": "^2.0",
        "drupal/config_split": "^2.0",
        "drupal/core-composer-scaffold": "^11.1",
        "drupal/core-project-message": "^11.1",
        "drupal/core-recommended": "^11.1",
        "drupal/easy_breadcrumb": "^2.0",
        "drupal/field_group": "^3.6",
        "drupal/focal_point": "^2.1",
        "drupal/gin": "^3.0",
        "drupal/gin_lb": "^1.0@RC",
        "drupal/gin_login": "^2.1",
        "drupal/honeypot": "^2.2",
        "drupal/inline_block_title_automatic": "^2.0",
        "drupal/layout_builder_browser": "^1.8",
        "drupal/layout_builder_modal": "^2.0",
        "drupal/layout_builder_operation_link": "^2.2",
        "drupal/metatag": "^2.1",
        "drupal/pathauto": "^1.13",
        "drupal/preprocess": "^2.2",
        "drupal/redirect": "^1.11",
        "drupal/sam": "^1.3",
        "drupal/shield": "^1.8",
        "drupal/simple_sitemap": "^4.2",
        "drupal/twig_tweak": "^3.4",
        "drupal/ultimate_cron": "^2.0@beta",
        "drupal/webform": "^6.3@beta",
        "drush/drush": "^13.3",
        "vlucas/phpdotenv": "^5.6",
        "wikimedia/composer-merge-plugin": "^2.1"
    },
"require-dev": {
        "drupal/coder": "^8.3",
        "drupal/core-dev": "^11",
        "drupal/masquerade": "^2.0",
        "drupal/webprofiler": "^11.1",
        "phpstan/extension-installer": "^1.4"
    }

@reinimax did you test this patch?

Hello I have applied the patch but issue still persist for me.
My current website is in Drupal version - 11.0.13

Once I hit upgrade to 11.1.2 version. I am getting issue.
Then I applied the patch, The patch applied successfully. But issue still persists and site goes down.

I am adding screenshots and patch which I have used.

And Thank You

@nicxvan I tried both patches #19 and #23 as well as the diff from the merge request. They applied, but I still get the container is not initialized yet error.

If this helps, the site was created with Drupal 11.1.4 and on this version I have no problems. The error occurs when doing a drush cr immediately after the updating to 11.1.5. Since @raveen_thakur51 has the same problem when updating to 11.1.2, maybe the issue has something to do with updating core itself?