Migrate to OOP hooks

Created on 13 November 2024, 5 months ago

Problem/Motivation

We can migrate to OOP hooks for 3.3. The test for 10.3 will fail now, but the attribute is being backported, so it should be fixed with the 10.4 release.

Overall Drupal 11 compatibility can be addressed in the parent issue; this issue is only for the hooks migration, which is very straightforward.

πŸ“Œ Task
Status

Needs review

Version

3.2

Component

Code

Created by

πŸ‡―πŸ‡΅Japan ptmkenny

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ptmkenny
  • Merge request !70Migrate to OOP hooks β†’ (Open) created by ptmkenny
  • Pipeline finished with Failed
    5 months ago
    Total: 309s
    #337193
  • Pipeline finished with Failed
    5 months ago
    Total: 177s
    #337357
  • πŸ‡―πŸ‡΅Japan ptmkenny

    ptmkenny β†’ changed the visibility of the branch oop_hooks4 to hidden.

  • Pipeline finished with Canceled
    5 months ago
    Total: 251s
    #337366
  • Pipeline finished with Failed
    5 months ago
    Total: 302s
    #337376
  • Pipeline finished with Failed
    5 months ago
    Total: 301s
    #337386
  • Pipeline finished with Failed
    5 months ago
    Total: 159s
    #337394
  • Pipeline finished with Failed
    5 months ago
    Total: 175s
    #337396
  • Pipeline finished with Failed
    5 months ago
    Total: 173s
    #337398
  • Pipeline finished with Failed
    5 months ago
    Total: 559s
    #337502
  • Pipeline finished with Failed
    4 months ago
    Total: 230s
    #351711
  • πŸ‡ΊπŸ‡ΈUnited States mlncn Minneapolis, MN, USA

    Major, because a priority major is postponed for this currently. (This and πŸ“Œ Support OOP hooks Active (or combining them into one issue again) are needed for Field Encrypt to work on Drupal 11.1.)

    Definitely do think the hooks should be in separate files based on usage, loading only what is needed when it is needed is a big benefit of OOP hooks, but that can be a later code reorganization.

  • Pipeline finished with Failed
    24 days ago
    Total: 180s
    #444758
  • Pipeline finished with Failed
    24 days ago
    Total: 176s
    #444761
  • πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

    We should definitely make 4.x only 11.1.x and up. Trying to support 11.0.x and 11.1.x on the same branch will be extremely hard and not worth the work.

  • Pipeline finished with Failed
    23 days ago
    Total: 258s
    #445169
  • Pipeline finished with Failed
    23 days ago
    Total: 175s
    #445175
  • πŸ‡―πŸ‡΅Japan ptmkenny

    After some thought, I'm going to close this in favor of the parent issue πŸ“Œ Support OOP hooks Active .

    I originally spun off this issue because I thought there would be a way to support both 10 and 11.1+, but as pointed out in #9, because of the changes to the handling of eval(), there's really no good way to do this. So all work on hooks will go forward in the parent issue, and we will leave the 3.x branch with the conventional hooks.

Production build 0.71.5 2024