- Status changed to RTBC
almost 2 years ago 3:35pm 4 October 2023 - 🇯🇵Japan aniketto Tokyo
Having this feature definitely helps on top of the awesome work that this module does.
Tested patch in #9 and works as expected. Marking as RTBC.fwiw, my use case was to parse menu items having links to view pages with contextual filters in the url path and add them to active trail - which became easy thanks to the hook!
- Status changed to Needs work
almost 2 years ago 3:40pm 4 October 2023 - 🇨🇭Switzerland berdir Switzerland
Seems like the alter hook should maybe pass all possible patches so a module could pick one of those?
Also the service should gracefully handle when the injected service is not present, with an optional constructor argument and fall back to \Drupal::service() or people will have a fatal error that they might struggle to resolve.
- Status changed to Needs review
5 months ago 5:44am 11 February 2025 - 🇫🇷France tostinni
We encounter this fatal error so here is an updated patch with the fallback.
- First commit to issue fork.
- 🇬🇧United Kingdom nicrodgers Monmouthshire, UK
I've updated patch #9 to work with v2.2 (constructor function switched to setter injection).
Leaving as Needs Work because I haven't addressed the comments in #11. I wasn't sure how to make @tostinni's work to make ModuleHandler injection fall back to Drupal::service with this new setter injection method so I've left that for now. Help welcome :)