Overall status

Open on Drupal.org →

Created on 30 September 2024, 6 months ago

Doesn't work with D10.3 - we need the fix from 🐛 Use constraint instead of function validator Active
Doesn't work with imagemagick - see discussion in 🐛 The selected image handling toolkit 'imagemagick' can not process operation 'rotate'. Active
Doesn't handle flipped images - see discussion in 🐛 Flipped orientation flags ignored RTBC
When we adjust the image in hook_file_presave() it's "too late". The preview is wrongly oriented on the widget, and probably some thumbnail problems #3129355: Autorotated media items thumbnails distorted → .

Here are some suggestions

We remove exif_orientation_file_presave() and instead always add an upload validator. This simplifies the code and solves the "too late" problems. Hence we remove _exif_orientation_rotate() and the code can be directly in the FileImageExifOrientationConstraintValidator.
We could copy 4 files from image_effects to give the auto_orient and mirror operations. This significantly simplifies the validation code, removes the (now incorrect) orientation from the EXIF and it can handle flipped images. However what would happen if both modules are installed? Can we make ours lower priority? Maybe we pick different operation names??

🌱 Plan

Status

Active

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom adamps

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!13Overall status
Open
🇬🇧United Kingdom adamps
updated 6 months ago

Comments & Activities

Issue created by @adamps
Comment 6 months ago →
🇬🇧United Kingdom adamps
Merge request !13Overall combined fix → (Open) created by adamps
Comment 6 months ago →
🇬🇧United Kingdom adamps
Pipeline finished with Success
6 months ago
Total: 153s
#298214
Pipeline finished with Success
6 months ago
Total: 153s
#298215
Pipeline finished with Success
6 months ago
Total: 184s
#298700
Status changed to Needs review 4 months ago8:13pm 18 December 2024
Comment 4 months ago →
🇺🇸United States msielski
Found this issue via issue #3401578. I'm not able to use the solution here because of the change from using hook_file_presave to only using a form alter. In my use case, images are created via another module (media_acquiadam, but I imagine any situation where images come in via an API would be affected), so the form alter approach gets skipped while the the hook_file_presave approach would work.
Comment 2 months ago →
🇷🇴Romania alex.stanciu
Here's a patch for this MR which adds support for the imagick toolkit, if you find it useful.
Comment about 2 months ago →
🇬🇧United Kingdom adamps
@msielski Yes you are right, good point.

@staalex Thanks

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024