- Issue created by @klimp
- Status changed to Needs review
5 months ago 6:52pm 16 July 2024 - 🇨🇦Canada klimp Montréal, QC
Because the issue fork includes
composer.json
please don't use a patch. Otherwise it won't pull dependencies.Use the fork repo instead:
{ "type": "composer", "url": "https://packages.drupal.org/8", "exclude": [ "drupal/exif_orientation" ] },
{ "type": "git", "url": "https://git.drupalcode.org/issue/exif_orientation-3461811.git" }
Then call
composer require drupal/exif_orientation:dev-3461811-imagemagick-rotate
- Status changed to Needs work
3 months ago 8:37pm 30 September 2024 - 🇬🇧United Kingdom adamps
If we require image_effects this is a big change for this module. It causes problems for sites upgrading who won't have the dependency installed. Also it pulls in another module file_mdm, and it adds a lot of extra settings for image effects. Perhaps not everyone wants this, especially those using gd. Currently this module is very small and simple which is attractive.
On the other hand, if we do have image_effects, then we should use the auto_rotate command as described in 🐛 The module doesn't work with Imagick toolkit Active . This simplifies the code, removes the (now incorrect) orientation from the EXIF and it can handle flipped images.
I can see some options:
- We could copy 4 files from image_effects to give the
auto_orient
andmirror
operations. However what would happen if both modules are installed? Can we make ours lower priority? Maybe we pick a different name? - We could instead write code that uses image_effects if it is found. However if the module is missing it's OK so long as the toolkit isn't imagemagick.
- We could copy 4 files from image_effects to give the
- 🇬🇧United Kingdom adamps
I now have a patch that hopefully fixes this issue and several others in 🌱 Overall status Active . Please help to test and review.