Use constraint instead of function validator

Open on Drupal.org →

Created on 4 July 2024, about 1 year ago

Problem/Motivation

As of Drupal 10.2.0 using function validators is deprecated and a validation constraint must be used instead.

Additionally, the current implementation in hook_field_widget_single_element_form_alter only adds the exif_orientation_validate_image_rotation validator function if the widget already has the file_validate_image_resolution validator function set.

This does not work anymore, because the file_validate_image_resolution validator function has been replaced by the FileImageDimensions validation constraint.

Steps to reproduce

Use this module 8.x-1.4 in Drupal >= 10.2.

Proposed resolution

Implement a validation constraint for image exif orientation and add the new constraint in hook_field_widget_single_element_form_alter if the widget already has the FileImageDimensions constraint set.

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇦🇹Austria chfoidl Salzburg

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!10Use constraint instead of function validator
Open
🇦🇹Austria chfoidl
updated 9 months ago

Comments & Activities

Issue created by @chfoidl
Comment about 1 year ago →
🇦🇹Austria chfoidl Salzburg
Comment about 1 year ago →
🇦🇹Austria chfoidl Salzburg
chfoidl → changed the visibility of the branch 8.x-1.x to hidden.
Merge request !10Issue #3458955: Use constraint instead of function validator → (Open) created by chfoidl
Pipeline finished with Success
about 1 year ago
Total: 157s
#215441
First commit to issue fork.
Pipeline finished with Success
12 months ago
Total: 153s
#228906
First commit to issue fork.
Comment 9 months ago →
🇬🇧United Kingdom adamps
I closed 🐛 Orientation is not present if a maximum image dimension is set on the field Active as a duplicate however I copied the title from there as it will help people understand what the bug is (rather than what the fix is).
Comment 9 months ago →
🇬🇧United Kingdom adamps
Great thanks, it works, although there is some code that could be removed - see comments in MR.
Comment 9 months ago →
🇬🇧United Kingdom adamps
I now have a patch that hopefully fixes this issue and several others in 🌱 Overall status Active . Please help to test and review.
Status changed to RTBC 2 months ago7:24pm 5 May 2025
Comment 2 months ago →
🇵🇹Portugal jrochate
This patch solved the problem when the image field has max dimensions set.
Drupal 10.4 and stable exif_orientation 1.5 and also using imagick 1.12

Sorry, @adamps but your combo fix didn't solved the problem, so setting this as RTBC

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024