Phpcs Code Standard Issue

Hello,

I have created a patch to solve all the errors related to phpcs code standard.

When I am applying the patch it is showing me below errors:

Checking patch web/modules/contrib/admin_toolbar/admin_toolbar_search/css/admin.toolbar_search.css...
error: web/modules/contrib/admin_toolbar/admin_toolbar_search/css/admin.toolbar_search.css: No such file or directory
Checking patch web/modules/contrib/admin_toolbar/admin_toolbar_search/js/admin_toolbar_search.js...
error: web/modules/contrib/admin_toolbar/admin_toolbar_search/js/admin_toolbar_search.js: No such file or directory
Checking patch web/modules/contrib/admin_toolbar/js/jquery.hoverIntent.js...
error: web/modules/contrib/admin_toolbar/js/jquery.hoverIntent.js: No such file or directory

Let me work on it.

The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.

Found one error remaining. Committing changes in the MR.

Patch to solve all the errors related to phpcs code standard.
Not interdiff because none of the above patch applied.

The last submitted patch, 14: 3366199-12.patch, failed testing. View results →

Addressing #6 and updating issue summary and required command with arguments.
Please review.

Issue summary updated.

keshav.k → made their first commit to this issue’s fork.

I have scanned the module against 3.x branch with phpcs ../vendor/bin/phpcs --standard=drupal modules/contrib/admin_toolbar and fix the remaining issues.
Please do not fix the following JS issues, As it will throw a JS error.

FILE: /var/www/html/web/modules/contrib/admin_toolbar/js/jquery.hoverIntent.js
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
 67 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/admin_toolbar/admin_toolbar_search/js/admin_toolbar_search.js
-----------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------
 13 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 61 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 66 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------

Please review.
Thank you.

I've conducted a local test and everything is functioning as expected. It's only presenting JavaScript errors, which we don't require to rectify.
It appears ready to be transitioned to RTBC

Automatically closed - issue fixed for 2 weeks with no activity.

dydave → closed merge request !60