- Issue created by @Prachi6824
- 🇮🇳India Prachi6824
Hello,
I have created a patch to solve all the errors related to phpcs code standard.
- Assigned to sourabhjain
- Status changed to Needs work
almost 2 years ago 1:07pm 12 June 2023 - 🇮🇳India sourabhjain
When I am applying the patch it is showing me below errors:
Checking patch web/modules/contrib/admin_toolbar/admin_toolbar_search/css/admin.toolbar_search.css... error: web/modules/contrib/admin_toolbar/admin_toolbar_search/css/admin.toolbar_search.css: No such file or directory Checking patch web/modules/contrib/admin_toolbar/admin_toolbar_search/js/admin_toolbar_search.js... error: web/modules/contrib/admin_toolbar/admin_toolbar_search/js/admin_toolbar_search.js: No such file or directory Checking patch web/modules/contrib/admin_toolbar/js/jquery.hoverIntent.js... error: web/modules/contrib/admin_toolbar/js/jquery.hoverIntent.js: No such file or directoryLet me work on it.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - @sourabhjain opened merge request.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 1:13pm 12 June 2023 - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Status changed to Needs work
almost 2 years ago 7:17pm 12 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.
- Assigned to nitin_lama
- 🇮🇳India nitin_lama India
Found one error remaining. Committing changes in the MR.
- last update
almost 2 years ago 14 pass, 4 fail - Issue was unassigned.
- 🇮🇳India bhaveshithape
Patch to solve all the errors related to phpcs code standard.
Not interdiff because none of the above patch applied. - Status changed to Needs review
almost 2 years ago 3:54am 15 June 2023 - last update
almost 2 years ago Patch Failed to Apply - last update
almost 2 years ago Patch Failed to Apply - last update
almost 2 years ago 14 fail The last submitted patch, 14: 3366199-12.patch, failed testing. View results →
- Status changed to Needs work
almost 2 years ago 12:17pm 15 June 2023 - 🇮🇳India ashutosh ahirwal India
Addressing #6 and updating issue summary and required command with arguments.
Please review. - 🇮🇳India keshavv India
keshav.k → made their first commit to this issue’s fork.
- last update
over 1 year ago 16 pass, 2 fail - Status changed to Needs review
over 1 year ago 11:42am 25 July 2023 - 🇮🇳India keshavv India
I have scanned the module against 3.x branch with phpcs
../vendor/bin/phpcs --standard=drupal modules/contrib/admin_toolbarand fix the remaining issues.
Please do not fix the following JS issues, As it will throw a JS error.FILE: /var/www/html/web/modules/contrib/admin_toolbar/js/jquery.hoverIntent.js ------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------- 67 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/contrib/admin_toolbar/admin_toolbar_search/js/admin_toolbar_search.js ----------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ----------------------------------------------------------------------------------------------------- 13 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 61 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 66 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" ----------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY -----------------------------------------------------------------------------------------------------Please review.
Thank you. - Status changed to RTBC
over 1 year ago 7:30am 28 July 2023 - 🇮🇳India aayushDrupal
I've conducted a local test and everything is functioning as expected. It's only presenting JavaScript errors, which we don't require to rectify.
It appears ready to be transitioned to RTBC -
adriancid →
committed 33b281b2 on 3.x
Issue #3366199 by sourabhjain, PrabuEla, nitin_lama, prachi6824, keshavv...
-
adriancid →
committed 33b281b2 on 3.x
- Status changed to Fixed
over 1 year ago 4:45pm 29 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.