Improve CORS configuration documentation

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Patch for Drupal version 10.1.x

Points in #33 were not addressed.

Not ready for review yet.

Now the strings are going over 80 characters per line.

Fixed docs' lines having characters above 80 in a single line.

Thanks!

does this need summary update?

The last submitted patch, 55: 2905848-55.patch, failed testing. View results →

Hi,

I tested the patch of #55 in d11, it works fine, applies cleanly. Since, the issue has changed to 11.x, providing the patch for 11.x.

Hiding #60. Thank you but #55 applied cleanly to 11.x so #60 is just a re-upload from what I can tell, since there was no interdiff.

Can run the 11.x tests by clicking the "Add test/retest" link. Queued #55 for 11.x tests.

But #57 I believe is correct in that IS should be updated about what is being accomplished. Me marking RTBC in #56 was incorrect on my part.

1. +++ b/core/assets/scaffold/files/default.services.yml
   @@ -160,15 +160,33 @@ parameters:
   +    # Setting exposedHeaders: ['*'] will result in a Access-Control-Expose-Headers:
   +    # * response header. See
   

   This line should wrap at 80 characters. This will also fix the fact that header name and value are currently split over 2 lines.

2. +++ b/core/assets/scaffold/files/default.services.yml
   @@ -160,15 +160,33 @@ parameters:
   +    # Setting Access-Control-Max-Age header value to '0' or false will omit this from the response.
   +    # However, setting it to '-1' will explicitly disable caching. For example, 600 to
   

   Line wrapping should be fixed.

It might make sense to merge 🐛 Improve documentation for cors configuration. Needs work and this issue, since that issue is about adding and documenting the new allowedOriginsPatterns-option to cors.config in default.services.yml.

Made changes as per comment #62.
Please review.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

This still needs a rebase which was not addressed in the creation of the MR.

Remember to hide all patch files when switching to a MR.

Hi @xjm @smustgrave
I intentionally deferred work on these issues. All the updates were made on November 14, 2023, and I've been addressing them sequentially in the Drupal issue queue without initially considering the tags assigned to each. I acknowledge this oversight and apologize for any confusion. Moving forward, I will ensure to prioritize and address issues based on their respective tags.

Updated the MR and fixed wrapping

Went ahead and updated issue summary.

Update text definitely reads like a net improvement.

nod_ → closed merge request !5410

Committed 6e7a674 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.