Fix the issues reported by phpcs

Hi

Your MR seems to have conflict with the base branch which blocks your merge request, I also tried to apply your MR !2 and below is what my terminal says

➜  expand_link_formatter git:(8.x-1.0-beta2) ✗ curl https://git.drupalcode.org/project/expand_link_formatter/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2791    0  2791    0     0   4603      0 --:--:-- --:--:-- --:--:--  4651
patching file expand_link_formatter.module
patching file 'src/Plugin/Field/FieldFormatter/ExpandLinkFormatter.php'
Reversed (or previously applied) patch detected!  Assume -R? [y] y
2 out of 4 hunks failed--saving rejects to 'src/Plugin/Field/FieldFormatter/ExpandLinkFormatter.php.rej'
➜  expand_link_formatter git:(8.x-1.0-beta2) ✗ 

hence I will move this issue to needs work and fix the conflict in your MR

Issue summary updated

Hi

MR #7 applied successfully.

Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib/expand_link_formatter (8.x-1.x)
$ curl https://git.drupalcode.org/project/expand_link_formatter/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   989    0   989    0     0   1969      0 --:--:-- --:--:-- --:--:--  1974
patching file src/Plugin/Field/FieldFormatter/ExpandLinkFormatter.php

Still some warnings are remaining

Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib
$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,js,yml expand_link_formatter/

FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\expand_link_formatter\src\Plugin\Field\FieldFormatter\ExpandLinkFormatter.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
  78 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 133 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 133 | WARNING | Only string literals should be passed to t() where possible
 134 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 134 | WARNING | Only string literals should be passed to t() where possible
----------------------------------------------------------------------------------------------------------------------------------------------

Time: 291ms; Memory: 10MB

Please review.

Hi

I applied the MR !2 after the commit #9 and This is the remaining PHPCS issues that my terminal is showing.

➜  expand_link_formatter git:(8.x-1.0-beta2) curl https://git.drupalcode.org/project/expand_link_formatter/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2310    0  2310    0     0   4382      0 --:--:-- --:--:-- --:--:--  4425
patching file 'src/Plugin/Field/FieldFormatter/ExpandLinkFormatter.php'
➜  expand_link_formatter git:(8.x-1.0-beta2) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml expand_link_formatter

FILE: ...and_link_formatter/src/Plugin/Field/FieldFormatter/ExpandLinkFormatter.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 133 | WARNING | Only string literals should be passed to t() where possible
 134 | WARNING | Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------

Time: 255ms; Memory: 10MB

➜  contrib git:(master) ✗ 

Mohd Sahzad → made their first commit to this issue’s fork.

Hi @clarkssquared,
I have fixed remaining PHPCS issues please review last commit in MR !2

Hi,

MR #13 applied successfully

Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib/expand_link_formatter (8.x-1.x)
$ curl https://git.drupalcode.org/project/expand_link_formatter/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2737    0  2737    0     0   7332      0 --:--:-- --:--:-- --:--:--  7377
patching file src/Plugin/Field/FieldFormatter/ExpandLinkFormatter.php

All the issues are resolved

Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib
$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,js,yml expand_link_formatter/

Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib
$