- Issue created by @jviitamaki
- Status changed to Needs review
12 months ago 9:06am 30 November 2023 - Status changed to Needs work
12 months ago 1:06pm 30 November 2023 - 🇬🇧United Kingdom adamps
Great thanks. I thought we'd fixed this! We deliberately store the header in lower-case internally to avoid collisions/confusion if people mix up the case.
Symfony does the same: in
Headers::add()
there is$name = strtolower($header->getName()); $this->headers[$name][] = $header;
What I rather carelessly didn't realise is that
$header->getName()
is still in camel case.Fortunately, I think there is an easy fix. In Email::getSymfonyEmail(), add a call to ucwords:
$headers->addMailboxListHeader(ucwords($name, '-'), $value);
- 🇫🇮Finland jviitamaki
That's way better solution and fixes, the issue. Patch included and merge request created.
- Status changed to Needs review
12 months ago 9:27am 4 December 2023 - 🇨🇿Czech Republic kyberman Czech Rep. 🇨🇿
Thank you very much @jviitamaki,
I can confirm your simple patch fixes the "{{ getSender(message) }}" problem for me.
Best regards
Vit - 🇬🇧United Kingdom adamps
Great thanks please can you add a comment "Convert headers to camel case" then I'll commit.
- Status changed to Needs work
11 months ago 11:39am 5 January 2024 - 🇬🇧United Kingdom adamps
Thanks however I meant to add a comment in the code
// Convert headers to camel case. $headers->addMailboxListHeader(ucwords($name, '-'), $value);
- First commit to issue fork.
- Assigned to sourabhjain
- Status changed to Needs review
11 months ago 1:01pm 5 January 2024 -
AdamPS →
committed b688c5fe on 1.x authored by
jviitamaki →
Issue #3405108 by jviitamaki, sourabhjain, AdamPS, kyberman: Headers...
-
AdamPS →
committed b688c5fe on 1.x authored by
jviitamaki →
- Status changed to Fixed
11 months ago 9:52am 7 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.