Fix the issues reported by phpcs

Hello, @urvashi_vora thanks for the patch, I have applied your patch and ran successfully.

These are the steps I followed:

1. Took clone from git version 1.0.x in drupal 10.1.x

2. Ran this command:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/y_donate/

3. Applied your patch and, again ran phpcs command

found errors

4. I have fixed that error with phpcbf.

Ran this command to fix the errors:

./vendor/bin/phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/y_donate/

Then again checked with phpcs:

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/y_donate/

5. Some warnings & errors are still there.

Needs work.

Aditi Saraf → made their first commit to this issue’s fork.

Hi,
I have fixed all the errors, please review my patch .

hi @aayushmankotia,
i have tested your patch: issuefixed-3373804-5.patch and it is fixing all the issues. Thanks for your patch. Moving to RTBC

+For further information, see [Installing Drupal Modules]
+(https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).

The markup for links is written on a single line. The correct text is the following.

For further information, see
[Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/installing-drupal-modules).

-3. Select **Add block** on the page, then search or scroll to find **Donation Form Embed Block**.
+3. Select **Add block** on the page, then search or scroll to find
+**Donation Form Embed Block**.

The last line is not correctly indented.

-Y Layout Builder - Donate: A submodule of this module, this will allow editors to create a call to action block in Layout Builder that directs users to the embedded donation form.
+Y Layout Builder - Donate: A submodule of this module, this will

The first line has been split after 65 characters.

+If your embedded form does not work in your non-production environment
+you may need to add a domain to the allow-list either on the provider-side
+or in your site's Content Security Policy.

The first line has been split after 70 characters. To reach 80 characters, you may could have been placed on the first line.

+**A1:** If your provider is not listed you can add the form by selecting
+the **Code** Custom Block and then pasting in your code.

The last line is not correctly indented.

 /**
  * @file
- *  Contains install and update functions for Y Layout Builder - Donate module.
+ * Contains install and update functions for Y Layout Builder - Donate module.
  */

The usual description for a .install file is Install, update, and uninstall functions for the [module name] module. where [module name] is the module name reported in the .info.yml file.

+   * Donation form provider.
+   *
    * Lists Form Providers for Donation form. To be overridden if a custom
    * provider is needed. Array key should be the same name as a twig file that

Since the method returns a list of form providers, it is not a form provider.

Providing updated patch. Please review.

Can we have Merge Request created, please?
Patch is 27Kb of size, it is not reviewable

We are in 21st century, Merge Request is a thing

Please review MR.

podarok → closed merge request !6

HI @Nikolay Shapovalov,

I have fixed phpcs isssue in above attached patch 10 , please review this patch

@Mohd Sahzad thanks for your patch.
But changes you provided doesn't make sense.
The name of the module is "Y Layout Builder - Donate", and you can split it into to sentences.
You can try to use module machine name.

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

I would rather use Install, update, and uninstall functions for the Y Layout Builder - Donate module. and ignore the report about the line length.

+1 for #20.

See also comment #11, where a project maintainer asked to use issue forks and merge requests for this issue. Comment #18 still uses a patch.

It is not possible to create an issue fork for the 2.0.x branch, from this issue.

Can we have Merge Request created, please? 📌 Fix the issues reported by phpcs Needs work

Anjali Mehta → made their first commit to this issue’s fork.

Kindly Review the MR.
Thank You.

I have removed the CSS file. Please review it now.

Automatically closed - issue fixed for 2 weeks with no activity.