missing @return in docs for ExternalEntityStorageClientInterface::query()

I've added the @return doc comment. Please review.

Thanks for the patch!

I'm not sure each item has to be an array, as one of the callers of this method does this:

    $query_results = $this->getStorageClient()->query($this->parameters, $this->sort, $start, $length);

SNIP 

    foreach ($query_results as $query_result) {

      $id = $field_mapper->extractIdFromRawData((array) $query_result);

Hi,

Patch #2 was applied cleanly to the External Entities module against 8.x-2.x-dev on Drupal 9.5.10, and confirmed that the ExternalEntityStorageClientInterface.php is now updated.

Checking patch src/StorageClient/ExternalEntityStorageClientInterface.php...
Applied patch src/StorageClient/ExternalEntityStorageClientInterface.php cleanly.

Please see the attached files for reference.

I'm moving this now to RTBC.

Thank you!

Needs work as per my comment.

@roberttabigue thanks for reviewing, but please don't upload screenshots of code! We can see the patch applies - the test is green. And we can see the change the patch makes -- that's what the diff is for.

Patch updated.
Please review.

+++ b/src/StorageClient/ExternalEntityStorageClientInterface.php
@@ -77,6 +77,9 @@ interface ExternalEntityStorageClientInterface extends PluginInspectionInterface
+   *   A single external entity or array of raw data arrays each representing an external entity.

It can't be a single entity, because:

    $query_results = $this->getStorageClient()->query($this->parameters, $this->sort, $start, $length);
    $field_mapper = $this->getExternalEntityType()->getFieldMapper();
    $result = [];
    foreach ($query_results as $query_result) {
      $id = $field_mapper->extractIdFromRawData((array) $query_result);
      if (!empty($id)) {
        $result[$id] = $id;
      }
    }

Updated patch as issue mentioned in #8. Please review.

Hi,

I reviewed the changes and it looks good on my end.

Moving this now to RTBC.

Thank you!

Thanks for the work

@pefferen I don't see you haven't given credit to anyone apart from you. Is there any specific reason?

No specific reason, I just forgot to set it properly, thanks for checking :)

@pefferen, it is normal to wait two weeks and let drupal.org automatically close issues. Now that you have force closed this issue no one else can re-open it should there be a regression to report.

When an issue is marked as Fixed and has no activity for 2 weeks, it is closed automatically.

thanks, @josepholstad I did not know, reopening to fixed

Automatically closed - issue fixed for 2 weeks with no activity.