- Issue created by @HitchShock
- First commit to issue fork.
- Assigned to sourabhjain
- Issue was unassigned.
- Status changed to Needs work
9 months ago 12:15pm 4 March 2024 - 🇮🇳India sourabhjain
Below are the PHPSTAN errors
PHP Warning: Undefined global variable $base_path in /var/www/html/drupal10/web/core/includes/common.inc on line 161 Warning: Undefined global variable $base_path in /var/www/html/drupal10/web/core/includes/common.inc on line 161 5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% ------ ---------------------------------------------------------------------------------------------------------------------------------------- Line src/PDFToImageBatchHelper.php ------ ---------------------------------------------------------------------------------------------------------------------------------------- 117 Parameter $pdf of method Drupal\pdf_to_imagefield\PDFToImageBatchHelper::generateProcessPage() has invalid type Spatie\PdfToImage\Pdf. 133 Parameter $pdf of method Drupal\pdf_to_imagefield\PDFToImageBatchHelper::generatePage() has invalid type Spatie\PdfToImage\Pdf. ------ ---------------------------------------------------------------------------------------------------------------------------------------- ------ --------------------------------------------------------------------- Line src/PDFToImageManager.php ------ --------------------------------------------------------------------- 169 Instantiated class Spatie\PdfToImage\Pdf not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols ------ --------------------------------------------------------------------- ------ ----------------------------------------------------------------------------------- Line src/Plugin/Field/FieldWidget/PDFToImageWidget.php ------ ----------------------------------------------------------------------------------- 64 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ -----------------------------------------------------------------------------------I just investigated on the above and it showing imagick extension is missing as per https://github.com/spatie/pdf-to-image/issues/145
- 🇺🇦Ukraine HitchShock Ukraine
Hi @sourabhjain
Seems like php extension doesn't exist only on your local env, that's why you have such PHPStan errors.
According to
https://git.drupalcode.org/project/pdf_to_imagefield/-/jobs/947631
https://git.drupalcode.org/issue/pdf_to_imagefield-3425194/-/jobs/976016
there is only one PHPStan error------ ------------------------------------------------------------------------------ Line src/Plugin/Field/FieldWidget/PDFToImageWidget.php ------ ------------------------------------------------------------------------------ 64 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ - 🇮🇳India dev2.addweb
nilesh.addweb → made their first commit to this issue’s fork.
- 🇮🇳India dev2.addweb
Hi,
I have fixed remaining phpcs and phstan error.beofre phpstan-->
5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% ------ ---------------------------------------------------------------------------------------------------------------------------------------- Line src/PDFToImageBatchHelper.php ------ ---------------------------------------------------------------------------------------------------------------------------------------- 117 Parameter $pdf of method Drupal\pdf_to_imagefield\PDFToImageBatchHelper::generateProcessPage() has invalid type Spatie\PdfToImage\Pdf. 133 Parameter $pdf of method Drupal\pdf_to_imagefield\PDFToImageBatchHelper::generatePage() has invalid type Spatie\PdfToImage\Pdf. 146 Fetching deprecated class constant EXISTS_RENAME of interface Drupal\Core\File\FileSystemInterface: in drupal:10.3.0 and is removed from drupal:12.0.0. Use \Drupal\Core\File\FileExists::Rename instead. 175 Fetching deprecated class constant EXISTS_ERROR of interface Drupal\Core\File\FileSystemInterface: in drupal:10.3.0 and is removed from drupal:12.0.0. Use \Drupal\Core\File\FileExists::Error instead. ------ ---------------------------------------------------------------------------------------------------------------------------------------- ------ --------------------------------------------------------------------- Line src/PDFToImageManager.php ------ --------------------------------------------------------------------- 169 Instantiated class Spatie\PdfToImage\Pdf not found. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols ------ --------------------------------------------------------------------- ------ ----------------------------------------------------------------------------------- Line src/Plugin/Field/FieldWidget/PDFToImageWidget.php ------ ----------------------------------------------------------------------------------- 64 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ----------------------------------------------------------------------------------- [ERROR] Found 6 errorsAfter fixing some phpstan and added spatie as per #5 -->
5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% [OK] No errors - 🇮🇳India dev2.addweb
Now all pipeline job is green, Need to check composer.json which I have been updated for build pass and need to check after composer-lint.
Before --> https://git.drupalcode.org/issue/pdf_to_imagefield-3425194/-/pipelines/2...
After --> https://git.drupalcode.org/issue/pdf_to_imagefield-3425194/-/pipelines/2... - Status changed to Needs review
4 months ago 7:16pm 22 July 2024