PHPCS and PHPStan errors

Created on 3 March 2024, 4 months ago
Updated 4 March 2024, 4 months ago

Problem/Motivation

Fix PHPCS and PHPStan errors.
See

Proposed resolution

Fix phpcs and phpctsn errors according to gitlab-ci

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇺🇦Ukraine HitchShock Ukraine

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @HitchShock
  • First commit to issue fork.
  • Assigned to sourabhjain
  • Merge request !3#3425194: Phpcs and phpstan errors → (Open) created by sourabhjain
  • Pipeline finished with Success
    4 months ago
    Total: 187s
    #110418
  • Issue was unassigned.
  • Status changed to Needs work 4 months ago
  • 🇮🇳India sourabhjain

    Below are the PHPSTAN errors

    PHP Warning:  Undefined global variable $base_path in /var/www/html/drupal10/web/core/includes/common.inc on line 161
    Warning: Undefined global variable $base_path in /var/www/html/drupal10/web/core/includes/common.inc on line 161
     5/5 [â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“â–“] 100%
    
     ------ ---------------------------------------------------------------------------------------------------------------------------------------- 
      Line   src/PDFToImageBatchHelper.php                                                                                                           
     ------ ---------------------------------------------------------------------------------------------------------------------------------------- 
      117    Parameter $pdf of method Drupal\pdf_to_imagefield\PDFToImageBatchHelper::generateProcessPage() has invalid type Spatie\PdfToImage\Pdf.  
      133    Parameter $pdf of method Drupal\pdf_to_imagefield\PDFToImageBatchHelper::generatePage() has invalid type Spatie\PdfToImage\Pdf.         
     ------ ---------------------------------------------------------------------------------------------------------------------------------------- 
    
     ------ --------------------------------------------------------------------- 
      Line   src/PDFToImageManager.php                                            
     ------ --------------------------------------------------------------------- 
      169    Instantiated class Spatie\PdfToImage\Pdf not found.                  
             💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
     ------ --------------------------------------------------------------------- 
    
     ------ ----------------------------------------------------------------------------------- 
      Line   src/Plugin/Field/FieldWidget/PDFToImageWidget.php                                  
     ------ ----------------------------------------------------------------------------------- 
      64     Unsafe usage of new static().                                                      
             💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
     ------ ----------------------------------------------------------------------------------- 
    

    I just investigated on the above and it showing imagick extension is missing as per https://github.com/spatie/pdf-to-image/issues/145

  • 🇺🇦Ukraine HitchShock Ukraine

    Hi @sourabhjain
    Seems like php extension doesn't exist only on your local env, that's why you have such PHPStan errors.
    According to
    https://git.drupalcode.org/project/pdf_to_imagefield/-/jobs/947631
    https://git.drupalcode.org/issue/pdf_to_imagefield-3425194/-/jobs/976016
    there is only one PHPStan error

     ------ ------------------------------------------------------------------------------ 
      Line   src/Plugin/Field/FieldWidget/PDFToImageWidget.php                             
     ------ ------------------------------------------------------------------------------ 
      64     Unsafe usage of new static().                                                 
             💡 See:                                                                       
                https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
     ------ ------------------------------------------------------------------------------ 
    
Production build 0.69.0 2024