Rewriting the text displayed for "- All -" label should occur before translation

Did anyone find a solution for this? I'm also running into the issue that a rewritten label cannot be translated.

Hey, any solution for this ?

I faced the same issue and I dived into the topic. The problem is that view exposed form, which is altered by Better Exposed Filters contains translated options already, so we are not able to read original labels in the alter function..
Another option would be using keys to determine options to overwrite, but I see some points that it users labels now, as using keys may be tricky sometimes as well when you have some ids as keys value. I guess there is no clear choice.

I've prepared a patch which adds "Rewrite the text displayed based on key" checkbox which allows using key|Label values to overwrite labels.

Can we add a test case for this.

I will handle it and I'll make merge request when ready.

@smustgrave pushed mentioned changes + unit tests to cover it to issue fork, created merge request as well.

Test looks great! But if we are adding a new configuration key it'll need a schema entry and update hook.

> But if we are adding a new configuration key it'll need a schema entry and update hook.

I've applied mentioned changes.

@ad0z excellent test cases! Ran the test-only feature and it shows the coverage is good.

Tested manually and can confirm the replacement is working excellently.

Update ran fine too.

smustgrave → closed merge request !68

Automatically closed - issue fixed for 2 weeks with no activity.