🇵🇱Poland @ad0z

Thanks @bonrita for suggestions.
I have pushed suggestions to dev branch, it will be part of next release.

ad0z → made their first commit to this issue’s fork.

Merged and released in 1.2.0.

Merged and released in 1.2.0.

Merged and released in 1.2.0.

Merged and released 1.2.0

ad0z → changed the visibility of the branch 3507059-missing-composer.json-file to active.

ad0z → changed the visibility of the branch 3507059-missing-composer.json-file to hidden.

I've faced the same issue and #2 patch resolved it. Thanks!

@megachriz

Ohh sorry, missed that. Fixed + updated tests to check if autocreate option is available in form.

@kim.pepper created merge request with hook update. https://git.drupalcode.org/project/search_api_opensearch/-/merge_request...

ad0z → changed the visibility of the branch 3381020-disable-ssl to hidden.

ad0z → changed the visibility of the branch 3381020-disable-ssl-verification-option to hidden.

ad0z → created an issue.

I've rerolled the @afi13 code to work on 2.x branch, additionally updated StandardConnector getConfiguration function because default value for websites with installed module already was not picked up. I believe it's expecting way to resolve this issue.

It's related with core REST module itself, and cannot be changed here, additionally it does not seem to be issue. https://www.drupal.org/project/drupal/issues/2990879 →

ad0z → created an issue.

@jkingsnorth thanks for the MR, seems good to me. Tested and seems to resolve the issue and work as expected.

@useernamee published new release.

Updated MR to add leading zero for internal urls if not available, added mentioned scenario to tests cases as well.

ad0z → changed the visibility of the branch 3396702-regression-related-to to hidden.

ad0z → created an issue.

I've added explicitly limiting of request_uri to 2048 characters to prevent errors when it exceeds the max length. Merge request merged to 2.x.

@Emircan Erkul

Could you provide more information? Steps to reproduce it?
When redirectToEntityEditForm function is not executed, default Drupal behaviour redirect browser based on "destination" query parameter or entity "collection" link(when destination is not provided) or default link template(when none of them is provided). That's kinda interesting how you got redirected to delete form then..

I did some manual testing and seems to be working on D11.

ad0z → created an issue.

@JKingsnorth I don't think there is a need to update field type from string to long_string, as string is representation of varchar which max lenght is 65,535 characters.. and as you mention we would have to take care of migration data, I don't think foreach and single update query would be a good idea, because it would take too much time for bigger sets of data. (maybe chunks could be better.. still it's not needed in my opinion)
I've created simple hook update to set column schema length value to 2048, and added needed changes to rest_log entity to apply it to new installations.
Could you test it and review the merge request? https://git.drupalcode.org/project/rest_log/-/merge_requests/14

ad0z → made their first commit to this issue’s fork.

Merged to dev branch.

@fago @useernamee can you guys familiarize with my last comment in rest log mirror issue( https://www.drupal.org/project/rest_log/issues/3432400#comment-15563623 ✨ Add support for Lupus Decoupled Drupal Fixed ) and update your merge request with needed changes?

@useernamee I removed currentRouteMatch injection from RestLogSubscriber and moved it to the RestPageRouteCheck service, I think it makes more sense like that, as it was injected in RestLogSubscriber just for the purpose of RestPageRouteCheck. So, I updated it - I think it's better to do it now than later. I hope you don't mind it, please update your code as well by removing current route match from parameters. If you mind I can revert last commit commits.. but hope not :)

> But if we are adding a new configuration key it'll need a schema entry and update hook.

I've applied mentioned changes.

@smustgrave pushed mentioned changes + unit tests to cover it to issue fork, created merge request as well.

I will handle it and I'll make merge request when ready.

I faced the same issue and I dived into the topic. The problem is that view exposed form, which is altered by Better Exposed Filters contains translated options already, so we are not able to read original labels in the alter function..
Another option would be using keys to determine options to overwrite, but I see some points that it users labels now, as using keys may be tricky sometimes as well when you have some ids as keys value. I guess there is no clear choice.

I've prepared a patch which adds "Rewrite the text displayed based on key" checkbox which allows using key|Label values to overwrite labels.

I am not able to recreate it, I need more details or steps to reproduce it with fresh Drupal installation. Is there anybody facing this issue?

Okay, so I've added RouteCheckManager and replaced isRestPage, it should be quite easy to extend logging mechanism if needed now.
@fago and @useernamee can you guys review issue's fork, give feedback and let me know if we need more work to make Lupus integration happen..

@Anybody I need more info, as I tried to recreate it with no success. The table is provided by ContentEntityType plugin, so install/deletion should be handled automatically.

1. Was prefixes used in your database initially?
2. Do you have `rest_log` table(with no prefix) there(in "corrupted" database)?

@very_random_man thanks for catching it, pushed fix to 2.x branch, It will be part of next release. I've added try...catch, to catch any other errors in the future so we make sure module do not interfere call.

It's working for me with no issues as well, it makes sense at it is marked as deprecated and will be removed in D11, it will be working on D10.

@joshi.rohit100 updated MR, can you take a look?

role_based_global_text module supports Global: Text area only, so if you want to use other handler it won't work, slightly limiting,.

Created merge request with mentioned warnings fixes. Needs review.

Added browser tests, they are passing on related fork issue.
There are some phpcs, phpstan warnings, but they will be fixed in https://www.drupal.org/project/views_role_based_global_text/issues/3410907 📌 Depricated code, phpcs and phpstan fixes Active issue.

ad0z → created an issue.

I thought about it more and I think it's working as expected, when user has no permission to filter whenever it's exposed or not, it should be not applied, that's make sense more We can discuss it if you think differently, but I am moving issue to needs review now.

I think I found a bug, when user has no access to filter criteria - filter criteria is not applied to the view, I suppose it should not happen as view should be working as expected still. I will take a look at this.

@danrod I was testing it on 3.x and it was working as well, as we can see the issue is related with this part of code:

        const input = $(el).find('input[type="time"]');
        if (input.length === 0) {
          return;
        }

        // Set default hour and minute for the AddonTimepicker.
        var timeValues = input.val().split(':');

input.val() returns undefined, kinda strange, element should be loaded at this point, value is there as we can see on the screenshot. Can you check what input variable contains by console.log or debug?

Added tests, GitLab CI, fixed phpcs and phpstan issues, pipeline is passing successfully on the issue fork. Review needed and some manual testing as well.

Exposed filters access handler check has to be run before view build phrase as exposed filter form is build there.
I think we can clearly run field handlers remove at that point as well, I don't see a point we could not.
I've prepared solution for that, based on my research and @matsbla work.
I've pushed working solution for me on related issue's fork, and tomorrow I will prepare browser tests as well, to make sure it is working as expected.

Checked the issue and it is because module deny access to field, but not field's exposed form.

@danrod interesting and it seems I pushed everything and it's working for me. Are you sure you have setup everything correctly? Does it not work at all or maybe for one case only? Cache maybe? Can you check it again and provide more info?

@danrod I think I did not miss anything, but I can verify it tomorrow.

@danrod LGTM.

@danrod module's composer.json needs to be updated as well.

@danrod No worries, good idea. MR LGTM.

@danrod

1. As I see you are dropping support for D8/D9 for 2.x, I don't think we want to do it? (We can consider D8 drop, if we want to use hook_field_widget_single_element_form_alter, if not, we should drop D10 from 2.x and use hook used in 2.x already)
2. Using hook_field_widget_single_element_form_alter will drop D8 support, as the hook is not available in this core version.

@lostcarpark You can use OR in composer.json module version: ^1.1 || ^2.0@beta so the module should be handled automatically when core is updated.
https://www.drupal.org/docs/upgrading-drupal/upgrading-from-drupal-8-or-... →

ad0z → created an issue. See original summary → .

@danrod pushed changes to issue fork, I've tested it on D10 only.

@danrod Do you need help with it? (As the issue seems to be not moving)
The source and solution seems to be quite simple and I may fix it(just let me know or assign this issue to me), what I propose is to add a class "widget-WIDGET-NAME" to elements, instead of passing field name only, and update JS libraries to support widget init by class name.
Code:

      $element['#attached']['drupalSettings'][$callback_library['extension']][$callback_library_name][$field_name] = $js_options;

            if (call) {
              // Find the element by field name.
              var $element = $(
                'input[name^="' + fieldName + '["][class^="form-time"]', context
              );

needs to be rewritten to be more flexible.

Pushed fix to issue's fork.

ad0z → created an issue.

@imrodmartin in your example you return URI, so it does.
LinkItem(https://api.drupal.org/api/drupal/core%21modules%21link%21src%21Plugin%2...) has three properties: uri, title, options, so you can access them, you can as well render field using [block_content:field_button_link].
If you want go get url only, I think you should familiarize with this issue: https://www.drupal.org/project/token/issues/3112449 ✨ Token for link field URL Needs work
Anyway, it does not seem like the module issue.

@claudiu.cristea

That's the code which resolve stale permissions issue, I suppose we could put it into post_update hook.

  $legal_entities = array_keys(EntityLegalDocument::loadMultiple());
  $roles = Role::loadMultiple();
  foreach ($roles as $role) {
    $update = FALSE;
    $permissions = $role->getPermissions();
    foreach ($permissions as $permission) {
      preg_match("/^(legal view |legal re-accept )(.*)/", $permission, $match);
      $machine_name = $match[2] ?? NULL;
      // Check if there is legal entity matching to checked permission.
      if ($machine_name && !in_array($machine_name, $legal_entities)) {
        $role->revokePermission($permission);
        $update = TRUE;
      }
    }
    if ($update) {
      $role->save();
    }
  }

Pushed changes to 2.x.

ad0z → created an issue.

@claudiu.cristea added simple kernel test, but second point does not make sense for me..

>Indeed, we need an update path. Try and get some inspiration from entity_legal_post_update_9002().

Why do we need to update path? Did you mean update existing roles permissions?

@claudiu.cristea got it, I will code it.

Dialog is not triggered when "Enforce auto logout on admin pages" is unchecked only, it happens because code:

    // We need a backup plan if JS is disabled.
    if (!$is_altlogout && !$refresh_only && isset($_SESSION['autologout_last'])) {
      // If time since last access is > timeout + padding, log them out.
      $diff = $now - $_SESSION['autologout_last'];
      if ($diff >= ($timeout + (int) $timeout_padding)) {
        $autologout_manager->logout();
        // User has changed so force Drupal to remake decisions based on user.
        global $theme, $theme_key;
        drupal_static_reset();

I suppose it's because there is a bug in $refresh_only = $autologout_manager->refreshOnly(); which leads

function autologout_autologout_refresh_only() {
  if (!\Drupal::config('autologout.settings')->get('enforce_admin') && \Drupal::service('router.admin_context')->isAdminRoute(\Drupal::routeMatch()->getRouteObject())) {
    return TRUE;
  }

to be executed, and

 \Drupal::service('router.admin_context')->isAdminRoute(\Drupal::routeMatch()->getRouteObject())

returns FALSE even for admin pages.(\Drupal::routeMatch()->getRouteObject() is NULL)
It is caused by event priority $events[KernelEvents::REQUEST][] = ['onRequest', 100];.
When I remove it, it starts to working as expected and \Drupal::routeMatch()->getRouteObject() returns object. I don't have time to debug it more today, but it may be good start to resolve this issue.