- Issue created by @useernamee
- 🇦🇹Austria fago Vienna
You cannot add dev-dependencies in libraries in composer. well you can, but it would have no affect.
I think it might work to "suggest" it via composer suggest option + we can add it to our documentation. - Merge request !83Resolve #3441811 "Improve debuggingdeveloper experience" → (Merged) created by useernamee
- Assigned to fago
- Status changed to Needs review
9 months ago 12:04pm 22 April 2024 - 🇸🇮Slovenia useernamee Ljubljana
I added the rest log in require-dev and suggest in composer.json.
For checking api requests I've added a request check:
protected function isApiResponse(Request $request): bool { return $request->attributes->get('lupus_ce_renderer') || $request->getRequestFormat() == 'custom_elements'; }
I've also been considering some other ways, but this seemed the most straightforward. The module now works just on on/off - if enabled it logs and if not it doesn't. I think that for development experience this is enough.
- Status changed to Needs work
9 months ago 5:04pm 22 April 2024 - 🇵🇱Poland ad0z
@fago @useernamee can you guys familiarize with my last comment in rest log mirror issue( https://www.drupal.org/project/rest_log/issues/3432400#comment-15563623 ✨ Add support for Lupus Decoupled Drupal Fixed ) and update your merge request with needed changes?
- Status changed to Needs review
9 months ago 4:19pm 23 April 2024 - 🇸🇮Slovenia useernamee Ljubljana
Implemented the change from ✨ Add support for Lupus Decoupled Drupal Fixed
- Status changed to Needs work
9 months ago 2:57pm 10 May 2024 - 🇦🇹Austria fago Vienna
looks all good to me! however, the gitlab pipeline is failing with the changes. we need to make it accept it.
- 🇸🇮Slovenia useernamee Ljubljana
I wasn't aware that ✨ Add support for Lupus Decoupled Drupal Fixed was not released yet. I think we should be good now - at least for the CI part. I kind of didn't want to put the patch in the lupus_decoupled composer.json file because than I'd also have to add a patch as well.
- Status changed to Needs review
6 months ago 4:34pm 15 July 2024 - Status changed to Needs work
6 months ago 6:30am 5 August 2024 - 🇦🇹Austria fago Vienna
it's merged now, so we should do the same and remove the patch. Could someone update + verify it's all good, so we can move and merge this?
- Assigned to useernamee
- 🇸🇮Slovenia useernamee Ljubljana
I removed that rest_log patch and checked the gitlab workflow.
- 🇸🇮Slovenia useernamee Ljubljana
Anyways I had to put the patch back in place. The issue is that rest_log last release was in 2023. ✨ Add support for Lupus Decoupled Drupal Fixed was merged in April 2024.
- 🇸🇮Slovenia useernamee Ljubljana
I've contacted maintainers of REST Log module and asked them if they can create a new release. That's the easiest way forward, since if we add a patch we will need to remove it after new release.
- 🇸🇮Slovenia useernamee Ljubljana
tested locally. requests are being logged. I'm waiting for green pipeline.
-
useernamee →
committed c9bab50e on 1.x
Issue #3441811 by useernamee, fago, ad0z: Improve debugging/developer...
-
useernamee →
committed c9bab50e on 1.x
- Status changed to Fixed
5 months ago 3:31pm 23 August 2024 -
useernamee →
committed c9bab50e on 3336148-forms-simplified
Issue #3441811 by useernamee, fago, ad0z: Improve debugging/developer...
-
useernamee →
committed c9bab50e on 3336148-forms-simplified
Automatically closed - issue fixed for 2 weeks with no activity.