Improve debugging/developer experience with rest_log module

Created on 18 April 2024, about 2 months ago
Updated 10 May 2024, about 1 month ago

Problem/Motivation

✨ Add support for Lupus Decoupled Drupal Needs review - Rest Log module is now open for extension with rest_log.route_check_manager service. Let's implement in Lupus Decoupled Drupal as a dev dependency.

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇸🇮Slovenia useernamee Ljubljana

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @useernamee
  • 🇦🇹Austria fago Vienna

    You cannot add dev-dependencies in libraries in composer. well you can, but it would have no affect.
    I think it might work to "suggest" it via composer suggest option + we can add it to our documentation.

  • Assigned to fago
  • Status changed to Needs review about 2 months ago
  • 🇸🇮Slovenia useernamee Ljubljana

    I added the rest log in require-dev and suggest in composer.json.

    For checking api requests I've added a request check:

      protected function isApiResponse(Request $request): bool {
        return $request->attributes->get('lupus_ce_renderer') || $request->getRequestFormat() == 'custom_elements';
      }
    

    I've also been considering some other ways, but this seemed the most straightforward. The module now works just on on/off - if enabled it logs and if not it doesn't. I think that for development experience this is enough.

  • Status changed to Needs work about 2 months ago
  • @fago @useernamee can you guys familiarize with my last comment in rest log mirror issue( https://www.drupal.org/project/rest_log/issues/3432400#comment-15563623 ✨ Add support for Lupus Decoupled Drupal Needs review ) and update your merge request with needed changes?

  • Status changed to Needs review about 2 months ago
  • 🇸🇮Slovenia useernamee Ljubljana

    Implemented the change from ✨ Add support for Lupus Decoupled Drupal Needs review

  • Status changed to Needs work about 1 month ago
  • 🇦🇹Austria fago Vienna

    looks all good to me! however, the gitlab pipeline is failing with the changes. we need to make it accept it.

Production build 0.69.0 2024