[2.x] REST Log

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

Thank you for applying!
rest_log/src/EventSubscriber/RestLogSubscriber.php

Type Hinting
Because you use type declaration for your function arguments in the majority of your code.
Can you add a type for $event ?
public function logResponse($event): void

public function onException($event): void

Unused argument
I think you can remove $event

  public function terminate($event): void {
    foreach ($this->stack as $item) {
      $this->doLogResponse($item['request'], $item['response']);
    }
  }

Pushed changes to 2.x.

For these applications, we need a project where most of the commits (preferable all the commits) have been done by the person who created the application.

We give a new drupal.org role to the person who applies, basing on what that person understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API, not because of what the project maintainers as group understand about those topics. It is not possible to understand what a single person understands when the commits are done by more than a single person; that is the reason for which a project with commits by multiple maintainers cannot be used for these applications.

We need a project where most of the commits have been done by you, ad0z.

I am changing priority as per Issue priorities → .

This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.