- πΈπ°Slovakia coaston
Hello matsbla,
I just tested path #6 it does not work for the latest version with D10 support.
I can see the option in exposed filters now and I can configure the role, but nothing happens. Still visible for everyone. - Assigned to ad0z
- Status changed to Needs work
over 1 year ago 11:36pm 22 December 2023 - π΅π±Poland ad0z
Exposed filters access handler check has to be run before view build phrase as exposed filter form is build there.
I think we can clearly run field handlers remove at that point as well, I don't see a point we could not.
I've prepared solution for that, based on my research and @matsbla work.
I've pushed working solution for me on related issue's fork, and tomorrow I will prepare browser tests as well, to make sure it is working as expected. - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:34pm 23 December 2023 - π΅π±Poland ad0z
Added tests, GitLab CI, fixed phpcs and phpstan issues, pipeline is passing successfully on the issue fork. Review needed and some manual testing as well.
- Assigned to ad0z
- Status changed to Needs work
over 1 year ago 9:14am 24 December 2023 - π΅π±Poland ad0z
I think I found a bug, when user has no access to filter criteria - filter criteria is not applied to the view, I suppose it should not happen as view should be working as expected still. I will take a look at this.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:15pm 25 December 2023 - π΅π±Poland ad0z
I thought about it more and I think it's working as expected, when user has no permission to filter whenever it's exposed or not, it should be not applied, that's make sense more We can discuss it if you think differently, but I am moving issue to needs review now.