Add permissions for views exposed filters

Created on 7 January 2021, over 3 years ago
Updated 25 December 2023, 6 months ago

Also add an option to the FILTER CRITERIA

✨ Feature request
Status

Needs review

Version

2.0

Component

Code

Created by

πŸ‡ΈπŸ‡°Slovakia Jozef 95

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Hello matsbla,

    I just tested path #6 it does not work for the latest version with D10 support.
    I can see the option in exposed filters now and I can configure the role, but nothing happens. Still visible for everyone.

  • Assigned to ad0z
  • Status changed to Needs work 6 months ago
  • Exposed filters access handler check has to be run before view build phrase as exposed filter form is build there.
    I think we can clearly run field handlers remove at that point as well, I don't see a point we could not.
    I've prepared solution for that, based on my research and @matsbla work.
    I've pushed working solution for me on related issue's fork, and tomorrow I will prepare browser tests as well, to make sure it is working as expected.

  • Merge request !6Resolve #3191345 "Add permissions for" β†’ (Open) created by ad0z
  • Issue was unassigned.
  • Status changed to Needs review 6 months ago
  • Added tests, GitLab CI, fixed phpcs and phpstan issues, pipeline is passing successfully on the issue fork. Review needed and some manual testing as well.

  • Assigned to ad0z
  • Status changed to Needs work 6 months ago
  • I think I found a bug, when user has no access to filter criteria - filter criteria is not applied to the view, I suppose it should not happen as view should be working as expected still. I will take a look at this.

  • Issue was unassigned.
  • Status changed to Needs review 6 months ago
  • I thought about it more and I think it's working as expected, when user has no permission to filter whenever it's exposed or not, it should be not applied, that's make sense more We can discuss it if you think differently, but I am moving issue to needs review now.

Production build 0.69.0 2024