Actions reordering on views bulk forms

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased to latest head and fixed Merge conflict in MR #2931

Tried testing MR 2931

I see the reordering feature in the bulk operation view field.
But reordering and checking different items seems to have no baring.
I checked 2 items but all appear.

reordering and checking different items seems to have no baring.

@smustgrave, I don't understand what "no baring" means in this context. Could you, please, explain?

Meant that I couldn't reorder or remove actions with the change.

But is this needed anymore default option is no longer "delete". If still needed definitely will need an issue summary update.

Re #209, #213

@smustgrave ,

Thank you for looking at this.

Meant that I couldn't reorder or remove actions with the change.

This is not about removing actions. It's only about reordering of actions on a per-view basis. I've tested again manually and everything works as expected. Also, the tests are a proof that is working correctly.

The IS is explaining all these and doesn't need any change. However, I've tweaked a little the Proposed resolution to make it more clear.

Please re-read the scope and test again. For any issue I'm available here or on Slack. Thank you.

Can none 11.x branch be hidden or noted in IS which MR should be reviewed.

Assumed 4583 as that's the last one but appears to have a test failure.

Applied the MR though and can confirm I can change the order without issue.

claudiu.cristea → changed the visibility of the branch 2381293-delete-should-not to hidden.

claudiu.cristea → changed the visibility of the branch 2381293-delete-action-10.0.x to hidden.

claudiu.cristea → changed the visibility of the branch 2381293-delete-action-10.1.x to hidden.

Hide attached files

Added MR to be reviewed in IS

A new action has been introduced recently, in 79a07a4e, and that made the test fail. This is ready for review.

That seemed to address the test failure.

Retested the reordering and that functionality still works.

Updating credit

I'm triaging RTBC issues → . I read the IS, the comments, the MR and change record.

Thanks for keeping the Issue Summary up to date. I have moved the 'MR to review' to the 'proposed resolution' section because it is the proposed resolution. ;-)

Like @benjifisher, I am concerned about scope creep on this issue. The direction set in #4 states, "- Let Views add a weight to the action plugins, perhaps first hard coded, later with a sort option in the Views interface." I read that to mean the changes to the Views interface are to be done later. That is also a suitable separation of tasks here. And bring the patch size → down to something manageable for a review.

I spotted one nit in the MR (which I did not review) and the grammar in the change record needs work. However, I am not commenting or tagging for those because the scope issue should be settled first.

I am leaving at RTBC and will ask the committers.

The direction set in #4 states, "- Let Views add a weight to the action plugins, perhaps first hard coded, later with a sort option in the Views interface." I read that to mean the changes to the Views interface are to be done later. That is also a suitable separation of tasks here

That was more a proposal than setting the issue’s scope. And until #152 a different approach has been considered, which we considered to be functionally wrong, for the reasons expressed in #152. Of course we can separate the UI part in a follow-up but the work is already done here and it benefited from the contributions of UX and fronted devs.

idimopoulos → changed the visibility of the branch 2381293-delete-action-10.2.x to hidden.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rerolled

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rerolled

The phpcs job failed.

Setting back as RTBC as it was just very minor change in the PHPCS rules added recently

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

It needs merge of core/tests/fixtures/config_install/multilingual.tar.gz after 🐛 Pager h4 causes accessibility flag on many pages Fixed

Rebased to latest head but need to merge commits, a697018f and 78d40bad - Update /multilingual.tar.gz .

@claudiu.cristea by any chance do you remember what those changes are ?

Here's a patch for 10.3.x

Note that this MR has been already RTBCed in #233 ✨ Actions reordering on views bulk forms RTBC . Since then no change has been applied except:

• Reroll
• Update of core/tests/fixtures/config_install/multilingual.tar.gz (see #237 ✨ Actions reordering on views bulk forms RTBC )
• Update of fixture file from Drupal 9.4.0 to 10.3.0 (see #239 ✨ Actions reordering on views bulk forms RTBC )
• PHPCS fixed because of new rules in core
• CSS lint fixes because of new rules in core

Ready for a final review

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.