- Issue created by @akshay_d
- First commit to issue fork.
- Status changed to Needs review
9 months ago 4:31am 12 October 2023 - ๐ฎ๐ณIndia sakthi_dev
Fixed the issue from phpcs using command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml. Please review.
- Merge request !7Issue #3393380: Fix the PHPCS errors reported for the project โ (Open) created by uttam
- Status changed to Needs work
8 months ago 8:32am 26 October 2023 - ๐ฎ๐ณIndia akshay_d Bangalore
@sakthi_dev Thanks for working on the issue.
I can still see some errors/warning on the phpcs pipeline build
can we address that ?
Thanks
- ๐ฎ๐ณIndia sarwan
sarwan_verma โ made their first commit to this issueโs fork.
- Status changed to Needs review
8 months ago 10:46am 26 October 2023 - ๐ฎ๐ณIndia sarwan
Hi @akshay_d,
I have fixed this issue "Fix the PHPCS errors reported for the project". created MR.
please review and verify. - Status changed to RTBC
7 months ago 3:58am 22 November 2023 - ๐ต๐ญPhilippines clarkssquared
Hi
I applied MR !7 and I confirmed that it fixes all the PHPCS issues and erros in the module
โ style_entity git:(2.x) curl https://git.drupalcode.org/project/style_entity/-/merge_requests/7.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 5438 0 5438 0 0 9942 0 --:--:-- --:--:-- --:--:-- 10241 patching file 'src/Plugin/EntityReferenceSelection/UsesSelection.php' patching file 'src/Plugin/Field/FieldType/StyleEntityReferenceItem.php' patching file style_entity.module patching file style_entity.post_update.php patching file 'tests/src/Kernel/StyleEntityTest.php' โ style_entity git:(2.x) โ .. โ contrib git:(master) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml style_entity โ contrib git:(master) โ
- Status changed to Needs work
7 months ago 6:52pm 22 November 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
A summary must describe what needs to be changed, and eventually why. A screenshot is not sufficient, even in the case a patch/MR is provided.
In the case of bug reports, the steps to reproduce the bug should be provided too. In the case of coding standards issues found using an automatic tool, the report given by that tool must be quoted too, including the arguments passed to that tool, if it is a command line tool.Also, please do not use a screenshot to show the report generated by PHP_CodeSniffer or other CLI tools.
- Assigned to nitin_lama
- ๐ฎ๐ณIndia nitin_lama
There are still remaining issues that needs to get fixed. Updated the IS.
- Issue was unassigned.
- Status changed to Needs review
6 months ago 1:08pm 22 December 2023 - ๐ฎ๐ณIndia zkhan.aamir
Hi,
The patch #13 applied cleanly.
All the errors are fixed.
Please refer the screenshot. - Status changed to Needs work
6 months ago 12:34pm 10 January 2024 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
Also, the MR changes five files, while the report is only for one file. Either the report is not complete, or the MR is changing more files than necessary.
- First commit to issue fork.
- Status changed to Needs review
5 months ago 5:36pm 31 January 2024 - Status changed to RTBC
20 days ago 12:56pm 6 June 2024 - ๐ฎ๐ณIndia deepak5423
I have applied !MR7 no phpcs found.
It looks good to me.