Drupal\views\Plugin\views\cache\CachePluginBase->generateResultsKey() passes invalid data to CacheContextsManager->convertTokensToKeys

This was a bugsmash daily target. I ran the test that is in the patch and it fails, so I assumed this still needed to be done. larowlan confirmed that in slack.

This also needs an issue summary update, see Write an issue summary for an existing issue → for guidance.

Trying to improve the title

Adding Rerole for d10, As previous patch failed to apply on d10 and also most of the files already had the changes so there is minor change in the patch.

Regarding #46

also most of the files already had the changes

How so? I'm checking D10.1 and I don't see the changes for a few of those files. Also this lost test coverage so adding that tag back

Was previously tagged for issue summary which still needs to happen as well.

I've altered the existing test to support the new format brought by $cache_context->getContext()

Issue summary section for solution is missing.

Tagging for submaintainer to make sure they agree on the approach

Those asserts are not doing anything, see MR comment.

I feel like #27.1 was never addressed. My assumption is also that if CacheableMetadata::merge() has $result = clone $this;, then it seems kind of moot to assert($result instanceof CacheableMetadata);.

Comment #28 also touched on the ampersand but not sure if we really need that.

From a cache submaintainer point of view, I see nothing wrong here. Assertions are harmless, casting casche context return values to strings is too because worst case scenario that leads to a few cache entries no longer being reachable, at which point they get recalculated and stored again. Only been subsystem maintainer for a few months now, so will ask @catch before removing tag.

This looks fine conceptually, still NW per my latest comment, though.