Remove (or at least default to false) "Place a colon after the label" setting

lendude → changed the visibility of the branch 1899220-remove-or-at to hidden.

lendude → changed the visibility of the branch 1899220-remove-or-at to active.

Going through (very) old issues to clean up things.

Changing this still makes sense 10 years on, but might come with a bit more BC baggage than it did before.

So, the MR just changes the default value.

I would argue against doing much more here.
We shouldn't update existing Views on sites because that might break things.
Most Views will just ignore this, because if you are using a Table style this setting is actually ignored (this goes for all Views shipped by core that I could find).
We don't do tests for this normally, it's just a default setting getting changed, existing test for this might fail, lets see.

Only thing I could think of that might be sort of worth doing is setting this to false on all default Views that ship with core, so that the settings line up (even though they get ignored by all these Views anyway, so very limited use in that)

I agree with keeping the scope of this issue small. Fixing the tests that are affected and it should be ready to go.

For me a logical followup would be to be able to customize that character instead of being hardcoded to a colon

Couple of fails seem unrelated, fixed the ones that were also failing locally

Can the issue summary be updated for this one please.

Updates IS

Thanks! Seems pretty straight forward enough.

I read the IS, the comments and the MR. I didn't find any unanswered questions. I did add before/after screenshots to confirm the change and updated credit.

nod_ → closed merge request !10604

Committed fcc93f6 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.