Convert FilterPluginBase::build_group_form to use table rendering and remove theme function

Created on 2 May 2013, over 11 years ago
Updated 22 July 2023, over 1 year ago

Similar to #1968020: Convert ReorderDisplays to use table rendering and remove theme function β†’

Here is an initial patch that does alot of the work. Currently the main thing that is broken is the checkboxes for the default group, and haven't looked at modifying the validation and submit methods yet.

πŸ“Œ Task
Status

Postponed: needs info

Version

9.5

Component
Views UIΒ  β†’

Last updated 21 days ago

Created by

πŸ‡¬πŸ‡§United Kingdom damiankloip

Live updates comments and jobs are added and updated live.
  • VDC

    Related to the Views in Drupal Core initiative.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡³πŸ‡±Netherlands Lendude Amsterdam

    I think we should have an answer in #2 first:

    So do we really want to remove all the theme functions. Maybe we should discuss that first.

    I'm not sure what the motivation for removing all #theme usage would be? (it might exist, I just don't know it and would like to see it documented here before we move on this)

  • πŸ‡¬πŸ‡§United Kingdom longwave UK

    I think the question is: is there a reason for anyone to override this template? I am not sure we expect users to customise the Views UI at this level, in which case we probably don't need a template for it, and can simplify the code?

Production build 0.71.5 2024