Inject various dependencies into DisplayPluginBase

dimitriskr → changed the visibility of the branch 11.x to hidden.

I've also created a draft CR for this change

Finally, ready for review.

P.S. I've deliberatly put the issue node instead of the draft CR link to the trigger_error(), per a conversation with @berdir at Slack.

Left a comment on the MR.

But think the MR and maybe title should be updated as not super clear why the Rest plugin is needed to be updated.

RestExport plugin is updated because it extends PathPluginBase, which itself extends DisplayPluginBase

Feedback appears to be addressed.

I think we should use constructor property promotion here.

Good call on the constructor promotion.

For the follow up issue of removing these deprecations would recommend tagging for novice. Would be excellent for new users.

As per @catch's comment on the MR we can remove the constructor docs everywhere and we can use property promotion on all the classes.

The issue summary has 'Add BC layer' deleted - this is a fairly common extension point.
We're not obligated to provide a BC layer, but should we do the right thing and try to avoid hard breaking people's things without warning?

Added the constructor property promotion.
About the constructor docs, I cannot remove them because PHPCS will complain and tests will fail. Do I need to add a phpcs bypass for this to work?

@larowlan BC layer exists, it's crossed out because it is already done

@dimitriskr sorry haven't had a chance to get to this sooner. I believe we have probably missed the 11.1x window mind updating those for 11.2.x please

I'd assign the issue to you if I could

Left comments and questions on the MR.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.