Contrib.social

Improve naming and documentation to clarify hook execution order

Open on Drupal.org →
Created on 12 October 2012, over 12 years ago
Updated 15 May 2025, 5 days ago

Originally this issue was going to be "Re-name hook_views_pre_view()" based on a discussion with @dawehner, but the more I looked into it, the more I realized that a lot of the hook and method names could probably be changed:

In ViewExecutable::preview()

  1. Display set
  2. ViewExecutable::preExecute()
    1. Arguments set.
    2. hook_views_pre_view()
    3. Display handler's preExecute()
  3. Display handler's preview() method. In DisplayPluginBase, this runs ViewExecutable::render():
    1. ViewExecutable::execute()
      1. ViewExecutable::build() called:
        1. hook_views_pre_build()
        2. Query built.
        3. Displays attached.
        4. hook_views_post_build()
      2. hook_views_pre_execute()
      3. Query executed or data retrieved from cache.
      4. hook_views_post_execute()
    2. Pre-rendering done for exposed form, pager, and style plugin.
    3. hook_views_pre_render() executed for modules and then themes.
    4. Display rendered.
    5. Post-rendering for exposed form.
    6. hook_views_post_render() executed for modules and then themes.
  4. ViewExecutable::postExecute()

In ViewExecutable::executeDisplay()

  1. Display set.
  2. ViewExecutable::preExecute()
    1. Arguments set.
    2. hook_views_pre_view()
    3. Display handler's preExecute()
  3. Display handler's execute() method. In DefaultDisplay this runs ViewExecutable::render():
    1. ViewExecutable::execute()
      1. ViewExecutable::build() called:
        1. hook_views_pre_build()
        2. Query built.
        3. Displays attached.
        4. hook_views_post_build()
      2. hook_views_pre_execute()
      3. Query executed or data retrieved from cache.
      4. hook_views_post_execute()
    2. Pre-rendering done for exposed form, pager, and style plugin.
    3. hook_views_pre_render() executed for modules and then themes.
    4. Display rendered.
    5. Post-rendering for exposed form.
    6. hook_views_post_render() executed for modules and then themes.
  4. ViewExecutable::postExecute()
📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

views.module

Created by

🇺🇸United States xjm

Live updates comments and jobs are added and updated live.
  • VDC

    Related to the Views in Drupal Core initiative.

  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 5 days ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024