- Issue created by @luenemann
- Merge request !69Resolve #3461385 "merge field_types of fullcalendar_view_processor plugins" → (Open) created by luenemann
- Status changed to Needs review
about 2 months ago 8:56am 15 July 2024 - 🇦🇺Australia Mingsong 🇦🇺
Thanks @Matthias for reporting it and the MR.
I identify another issue, maybe, with the following line in that commit.
https://git.drupalcode.org/project/fullcalendar_view/-/commit/91125f112d...
I think the comparison should be changed to
if ($start_field_option['type'] === $fieldtype) { $valid = TRUE; break; }
- 🇦🇺Australia Mingsong 🇦🇺
Here is the patch for the MR.
https://git.drupalcode.org/project/fullcalendar_view/-/merge_requests/69...
We need someone has the Smart Date module or any other module that implements the fullcalendar_view_processor plugin installed on their site to test and confirm for us.
So I will leave it as 'Needs review'.
- Status changed to Needs work
about 2 months ago 12:32pm 23 July 2024 - 🇩🇪Germany luenemann Südbaden, Germany
@Mingsong thanks you for the review, sorry for the late response.
I have reviewed your changes and think they should be reverted, see the comments in the MR.
Maybe it is possible to add an integration test with smart_date. I'd like to give it a try.