Skip default argument for view URL does not work!

Re-roll patch Attached against Drupal 10.1.x

Discussed this with @xjm and @longwave at Drupal Dev Days and we all agree this checkbox should be removed.

• It hasn't worked since Drupal 8.0.0
• the functionality is very edge case
• the description and title of the field are very unclear as to what a user could expect this to do

Here we go. Removed the setting. Update hook added to remove from existing and newly imported config. Removed from all existing core config.

Updated the IS

Applied the patch and searched for default_argument_skip_url.
Found 19 instances that were in the test, update hook, or fixture for the test.
Ran the update hook to make sure that ran and it did without issue.

Think this is good.

xjm → credited longwave → .

Adding credits for DDD discussion.

The last submitted patch, 45: 981870-45.patch, failed testing. View results →

Unrelated fails

🐛 [random test failure] InstallerExistingConfig[SyncDirectory]MultilingualTest::testConfigSync Fixed fixed some config install tests, looks like we need work here for that.

🐛 Random test fail in Drupal\Tests\Component\Utility\RandomTest::testRandomMachineNamesUniqueness Needs work is a genuine random fail in the random component :)

Removed default_argument_skip_url from views.view.files and views.view.glossary from multilingual.tar.gz

No interdiff, because the only change is that tarball and interdiff on that is useless.

It really helps if you supply the correct tarball format _sigh_

Again, no interdiff, since the only change is in a tarball.

And maybe even not include the local test changes in an official patch.
#MustBeMondayMorning

Going to tentatively self back-to-RTBC.

- I didn't change any code.
- The only changes were made in a fixture, which wasn't testable before because of the re-enabling of the test in 🐛 [random test failure] InstallerExistingConfig[SyncDirectory]MultilingualTest::testConfigSync Fixed wasn't committed yet.

RTBC +1

To me this doesn't need a change record given we are just removing something that is entirely broken.

Committed f890b7f and pushed to 11.x. Thanks!

I would actually give this a change record.

Added small CR, if someone could review we can publish it, https://www.drupal.org/node/3382316 →

Looks good to me. Added version numbers and published the change record.

Automatically closed - issue fixed for 2 weeks with no activity.

There is a regression a reporter thinks may be caused by this issue.

Via @berdir:

something that I'm seeing pop up a lot in contrib tests is the removal of default_argument_skip_url, I've had that in ~3 out of 5 modules that I've worked on so far. It's key in a yml file, not sure where exactly detection of that would go

[...]

well, config schema validation fails
so the test fails

https://git.drupalcode.org/search?group_id=2&scope=blobs&search=%22defau... finds 1500 instances of this

So it looks like the fallout from this is much bigger than expected.

I am working on 📌 Support default_argument_skip_url views setting removal checking in Upgrade Status Active to side-add a deprecation for this in upgrade status at least. But based on that contrib search many more people will run into this.

This is another instance where we missed 🐛 Add proper deprecation notices in config entity presave bc layers Active .

If we'd done that at the time, then module tests with deprecation reporting enabled would have picked this up since the time it was committed.

We could still retrospectively add the deprecation support to 10.3.0 during beta maybe?

Opened #3450868: Add ViewsConfigUpdater deprecation support for default_argument_skip_url → .

I released https://www.drupal.org/project/upgrade_status/releases/4.3.2 → with support for checking for this one specific key deprecation. I don't think we have a generic way to statically detect config keys depreacted but would be happy to add support for that too there for a more general solution.

lowest branch