Add proper deprecation notices in config entity presave bc layers

Created on 28 April 2024, 8 months ago

Updated 27 May 2024, 7 months ago

Problem/Motivation

Related to 📌 [policy] Add proper deprecation notices in config entity presave bc layers Active which is now more for adding documentation.

Many hook_ENTITY_TYPE_presave() update helpers don't include a mechanism to issue deprecations when they're called outside hook_update_N(). This means that exported configuration in modules and tests constantly uses the hook_ENTITY_TYPE_presave() bc layer without deprecations being issued, which means if the maintainer doesn't remember to re-export it for a major release, it will start breaking in the next major version with no warning.

A current example is 📌 ckeditor5 and editor module tests rely on hook_editor_presave() bc layers Active .

We could still add 10.x issues to add the @trigger_error() to the various methods that are missing it, however it might be too late for most module's 11.x compatibility, so they're likely to find out via brokenness rather than the deprecation message.