ckeditor5 and editor module test config exports/stubs rely on hook_editor_presave() bc layers

Typed the wrong parent.

oops my idea didn't. Ignore #8

Pushed up some test fixes but that just doesn't feel right.

That actually looks pretty much what I'd expect from the original test failures when the presave was removed, what doesn't feel right?

That all instances of

    $editor = Editor::create([
      'format' => 'restricted_with_editor',
      'editor' => 'unicorn',
    ]);

now need to be

    $editor = Editor::create([
      'format' => 'restricted_with_editor',
      'editor' => 'unicorn',
      'image_upload' => [
        'status' => FALSE,
      ],
    ]);

✨ [PP-1] Mark parts of CKEditor 5 and Editor config schema as fully validatable Postponed is the issue that added the requirement (and should have updated the exported config/stubbed config at the same time).

So the approach is to update all those calls to include image_upload?

Yeah I think so, unless we decide the original issue was wrong and shouldn't have made this required, but even if we reversed that, the test config would still be correct, just a bit redundant, so making the change here doesn't do any harm. Would be good to get a +1 from Wim who worked on the original issue if possible.

I think this is because validation config changes haven't updated the test editor config (either YAML or where it's stubbed in PHP).

Right, invalid Editor::create([…]) calls were "automagically fixed" thanks to hook_editor_presave() 😬 (Whack-a-mole: we prevented one problem and created another!)

So +1 for the principle you proposed at 🐛 Add proper deprecation notices in config entity presave bc layers Active !

@smustgrave in #15:

So the approach is to update all those calls to include image_upload?

Yes.

🐛 But the revert of editor_filter_format_presave() is AFAICT incorrect. It was introduced in 2015, in #2557265: Synchronize editor status with paired text format status → , for very different reasons. We should keep that until 🌱 [META] Discuss: merge the Editor config entity into the FilterFormat config entity Active makes it obsolete.

Updated all tests in MR 7782 and added back editor_filter_format_presave() per #18, with a todo #3231354

Test should be green now.

https://git.drupalcode.org/project/drupal/-/merge_requests/7782 looks good and I think it is RTBC.

Should https://git.drupalcode.org/project/drupal/-/merge_requests/7675 be hidden?

smustgrave → changed the visibility of the branch 3442395-ckeditor5-and-editor to hidden.

Yup and the branch name for mine is bad I'll admit. I originally thought the fix was to remove those ckeditor4 fixtures

OK RTBCing https://git.drupalcode.org/project/drupal/-/merge_requests/7782

🐛 Add proper deprecation notices in config entity presave bc layers Active is open to try to resolve this in 10.4.x (and to hopefully prevent it happening again with new updates).

I reviewed this in two sessions because this is a new to me. Reading the comments and the test failures were helpful to fill in some blanks. I was largely following the path of smustgrave as he worked on this. And the comment by @Wim Leers in #18 was most helpful. Thank you.

I see that an @todo was added with a link to the followup, so that is fine.

In the end I agree that this is ready and I have updated credit.

Committed 918b862 and pushed to 11.x. Thanks!

Yay! :)

Automatically closed - issue fixed for 2 weeks with no activity.