Remove redundant hook_ENTITY_TYPE_presave() and ViewsConfigUpdater methods

pradhumanjain2311 → made their first commit to this issue’s fork.

This is choking on the ckeditor4 config in ckeditor5 module, we might need to split that out to its own issue since it looks non-trivial to untangle the test coverage.

ckeditor5 and editor are going to be more complicated, so I opened 📌 ckeditor5 and editor module tests rely on hook_editor_presave() bc layers Active .

What this is showing, is that we need to be stricter about requiring deprecation triggering in hook_entity_presave() implementations when they're not running in updates, then all these tests would have failed when the config validation was added (i.e. before commit, requiring the config to be fixed first) instead of now.

Appears to have some functional test failures.

We have a general problem that issues adding config entity update paths haven't always remembered to update shipped config, or to issue deprecations for non-upgrade-path-config-fixing in presave. Updated that config but going to need to figure out a way to make this harder to forget for everyone so that we can cleanly remove updates next time.

Should that be done here? Or good to mark?

#2913850: Trigger E_USER_DEPRECATED from config entity presave bc layers → is probably the place to work on that.

Sweet, looking at the MR and doing a search for hook_ENTITY_TYPE_presave(), the instances that are remaining in
ckeditor5, comment, user, and some tests seem fine as they don't appear to be doing $config_updater stuff.

So I believe this is good to go.

Removing no longer needed presave and ViewsConfigUpdater code is new to me. Therefor, I carefully reviewed these changes checking each one was correct and any related post_update hooks were removed etc. I didn't find any other fixtures that needed to be removed either.

Committed fecffbf and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.