Remove taxonomy hard dependency on node module

Created on 16 September 2014, over 10 years ago
Updated 5 October 2023, over 1 year ago

Problem/Motivation

Currently taxonomy module depends on the node module. Sometimes this is a problem if you are not using nodes but still want to categorize for example, users.

The dependency on node is mostly related to the views integration. There are some tokens that depends on the node module, but the basic functionality of taxonomy module could be used even if node module is not installed.

Proposed resolution

As a starting point we could move all the views integration and node tokens related code to the node module and check if taxonomy module is installed to provide the features moved.

As a long term solution, taxonomy module should be refactored to work with standard entities, not just nodes. This implies a lot of effort and upgrade paths to migrate the taxonomy_index_tid table. [@todo create a ticket to track this]

Remaining tasks

  1. Agree on proposed resolution.
  2. Create more tests to ensure that main functionality works when node module is installed and is not present.
📌 Task
Status

Needs work

Version

11.0 🔥

Component
Taxonomy 

Last updated about 19 hours ago

  • Maintained by
  • 🇺🇸United States @xjm
  • 🇬🇧United Kingdom @catch
Created by

🇩🇪Germany steamx

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇺🇸United States m.stenta

    Rebased the MR onto 10.1.x. The only change that was necessary was to remove the changes to the RDF module, which has been removed form core (see #3267515: Remove RDF from core ).

    Attached is a corresponding patch.

    Leaving this as "Needs work" per @longwave's comment #75.

  • Pipeline finished with Failed
    over 1 year ago
    Total: 200s
    #27381
  • last update over 1 year ago
    29,672 pass
  • 🇺🇸United States paul121 Spokane, WA

    Re-roll of the patch in #80 for 10.2.0. The TokenReplaceTest file has been removed.

  • 🇺🇸United States paul121 Spokane, WA

    And a re-roll for 10.2.x. There was a change to the TaxonomyTermPagerTest modules 8d2f88bf since 10.2.0 that conflicts. Having trouble generating the interdiff for this.

  • last update over 1 year ago
    25,796 pass, 1,817 fail
  • 🇺🇸United States bradjones1 Digital Nomad Life

    This needs to be an MR at this point, and fresh testing for the failing patch.

  • Pipeline finished with Failed
    11 months ago
    Total: 599s
    #164589
  • 🇺🇸United States bradjones1 Digital Nomad Life

    Just three failures, looks like they will be easy as they relate to test setup itself rather than failed test of functionality.

    https://git.drupalcode.org/issue/drupal-2339235/-/pipelines/164592/test_...

  • 🇺🇸United States m.stenta

    Rebased onto latest 11.x.

    Also attaching a (hidden) patch for 10.3.x for use with cweagans/composer-patches.

  • Pipeline finished with Failed
    7 months ago
    #270309
  • First commit to issue fork.
  • Pipeline finished with Failed
    7 months ago
    Total: 156s
    #285664
  • Pipeline finished with Failed
    7 months ago
    Total: 616s
    #285674
  • 🇩🇪Germany luenemann Südbaden, Germany
    • Fixed dependency in olivero_test module of system module
    • Code Style fix

    There's an error in TaxonomyImageTest

    Drupal\Tests\taxonomy\Functional\TaxonomyImageTest::testTaxonomyImageUpload
        Behat\Mink\Exception\ResponseTextException: The text "Created new term" was not found anywhere in the text of the current page.
    

    The error message on the page:

    You do not have access to the referenced entity (file: 1).

  • Pipeline finished with Failed
    5 months ago
    Total: 121s
    #327372
  • Pipeline finished with Canceled
    5 months ago
    Total: 66s
    #328763
  • Pipeline finished with Failed
    5 months ago
    Total: 853s
    #328764
  • Pipeline finished with Failed
    5 months ago
    Total: 150s
    #328791
  • Pipeline finished with Failed
    5 months ago
    Total: 517s
    #328800
  • Pipeline finished with Failed
    5 months ago
    Total: 523s
    #328815
  • Pipeline finished with Success
    5 months ago
    Total: 764s
    #328839
  • 🇩🇪Germany luenemann Südbaden, Germany

    Test are passing now!

    Fix

    • code style
    • phpstan basline
    • test dependencies to node
    • missing permission in tests
  • 🇩🇪Germany luenemann Südbaden, Germany

    Still need work for #75 (#67)

  • Pipeline finished with Failed
    5 months ago
    Total: 1190s
    #328855
  • 🇳🇿New Zealand quietone

    Changing to the DX special tag defined on Issue tags -- special tags .

  • 🇺🇸United States m.stenta

    Rebased onto 11.x.

    The biggest change was to move the node and taxonomy hook implementation changes to Hook classes, since 📌 [ignore] Convert everything everywhere all at once Active was merged.

    Also attached (and hidden) is a patch that works with 11.1.x, since that has some slight differences, and is useful for applying to the current stable release (11.1.5) via cweagans/composer-patches.

  • Pipeline finished with Failed
    4 days ago
    Total: 112s
    #461920
Production build 0.71.5 2024