- Issue created by @nicxvan
- 🇺🇸United States nicxvan
I think we have a path forward here:
apply patch to convert some that need manual conversion e.g module implemented alter and the alter deprecation
Then run conversion
Then apply test fix patches in test conversion issue
Then apply patches that revert conversions that can't be converted yet not created yet but this includes tests like the one for .inc loadingWrangle coding standards, initial testing this is probably a few minor things.
Check for any failures that arise from all things being converted and integrate into above step.
Run process during code freeze if possible.
All tests have resolutions except the functional htaccess test.
- 🇺🇸United States nicxvan
Conversion 3 patches used attached.
Order matters review the gist. - 🇺🇸United States nicxvan
Ok after the automated conversion, patch application, and new baseline it looks like there are three functions in the baseline that shouldn't be there, not sure why, but that's pretty minor, let's see if there are any new test failures.
- 🇺🇸United States nicxvan
Many, many failures, mostly due to function calls missing, it seems that tests call hooks directly more than expected. I'll see if we can address this with rector or identify another pattern.
The test conversion is working though so we can always fall back to one bulk update of the tests, then group the modules as needed.
- 🇨🇦Canada Charlie ChX Negyesi 🍁Canada
ghost of drupal past → made their first commit to this issue’s fork.
- 🇺🇸United States nicxvan
Good news I unintentionally deleted some proxy files.
We have some patches and a follow up.
- 🇺🇸United States nicxvan
Great news, only minor codestyle issues.
There are another 25 functions that were converted, but those fixes are minor I can add patches for them.
- 🇺🇸United States nicxvan
Tests are failing now mostly due to how I incorrectly fixed the missing hook functions now that they are methods on classes.
I need to call the actual hooks directly still. I'll update my local patch, that will take care of the majority of the issues.
- 🇺🇸United States nicxvan
Ok missing functions should be all fixed now, I also have a bigpipe patch so that is no longer manual.
- 🇺🇸United States nicxvan
0003 has an update coming, but in order to not lose anything here are the patches used in conversion7
Also 8 doesn't apply, but it's super easy to just fix the bigpipehooks arrays manually.