[ignore] Convert everything everywhere all at once

Created on 26 October 2024, 4 days ago

Problem/Motivation

Let's convert everything.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component

base system

Created by

🇺🇸United States nicxvan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @nicxvan
  • Merge request !9963Resolve #3483599 "Ignore convert everything" → (Open) created by nicxvan
  • Pipeline finished with Failed
    3 days ago
    Total: 167s
    #321731
  • Pipeline finished with Failed
    3 days ago
    Total: 144s
    #321735
  • Pipeline finished with Failed
    3 days ago
    Total: 190s
    #321741
  • Pipeline finished with Failed
    3 days ago
    Total: 134s
    #321802
  • Pipeline finished with Failed
    3 days ago
    Total: 738s
    #321807
  • 🇺🇸United States nicxvan

    I think we have a path forward here:

    apply patch to convert some that need manual conversion e.g module implemented alter and the alter deprecation
    Then run conversion
    Then apply test fix patches in test conversion issue
    Then apply patches that revert conversions that can't be converted yet not created yet but this includes tests like the one for .inc loading

    Wrangle coding standards, initial testing this is probably a few minor things.

    Check for any failures that arise from all things being converted and integrate into above step.

    Run process during code freeze if possible.

    All tests have resolutions except the functional htaccess test.

  • 🇺🇸United States nicxvan

    nicxvan changed the visibility of the branch 3483599-conversion2 to hidden.

  • 🇺🇸United States nicxvan

    Conversion 3 patches used attached.
    Order matters review the gist.

  • Merge request !9970Resolve #3483599 "Conversion3" → (Open) created by nicxvan
  • Pipeline finished with Failed
    2 days ago
    Total: 211s
    #322599
  • 🇺🇸United States nicxvan

    Ok after the automated conversion, patch application, and new baseline it looks like there are three functions in the baseline that shouldn't be there, not sure why, but that's pretty minor, let's see if there are any new test failures.

  • Pipeline finished with Failed
    2 days ago
    Total: 611s
    #322604
  • 🇺🇸United States nicxvan

    Many, many failures, mostly due to function calls missing, it seems that tests call hooks directly more than expected. I'll see if we can address this with rector or identify another pattern.

    The test conversion is working though so we can always fall back to one bulk update of the tests, then group the modules as needed.

  • 🇨🇦Canada Charlie ChX Negyesi 🍁Canada

    ghost of drupal past made their first commit to this issue’s fork.

  • Pipeline finished with Failed
    1 day ago
    Total: 608s
    #322911
  • Pipeline finished with Failed
    1 day ago
    Total: 143s
    #322928
  • Pipeline finished with Failed
    1 day ago
    Total: 629s
    #322964
  • 🇺🇸United States nicxvan

    Good news I unintentionally deleted some proxy files.

    We have some patches and a follow up.

  • 🇺🇸United States nicxvan
  • 🇺🇸United States nicxvan

    Another patch FileTestHooks

  • 🇺🇸United States nicxvan

    nicxvan changed the visibility of the branch 3483599-ignore-convert-everything to hidden.

  • 🇺🇸United States nicxvan

    ok I have converted everything.

    Patches are out of date

  • 🇺🇸United States nicxvan

    nicxvan changed the visibility of the branch 3483599-conversion3 to hidden.

  • Merge request !9977Resolve #3483599 "Conversion4" → (Open) created by nicxvan
  • Pipeline finished with Failed
    1 day ago
    Total: 161s
    #323159
  • Pipeline finished with Failed
    1 day ago
    Total: 194s
    #323162
  • 🇺🇸United States nicxvan

    Great news, only minor codestyle issues.

    There are another 25 functions that were converted, but those fixes are minor I can add patches for them.

  • Pipeline finished with Failed
    1 day ago
    Total: 496s
    #323180
  • Pipeline finished with Failed
    1 day ago
    Total: 127s
    #323217
  • Pipeline finished with Failed
    1 day ago
    Total: 149s
    #323226
  • Merge request !9979Resolve #3483599 "Conversion5" → (Open) created by nicxvan
  • Pipeline finished with Failed
    1 day ago
    Total: 1451s
    #323236
  • Pipeline finished with Failed
    1 day ago
    Total: 594s
    #323260
  • 🇺🇸United States nicxvan

    nicxvan changed the visibility of the branch 3483599-conversion4 to hidden.

  • 🇺🇸United States nicxvan

    Tests are failing now mostly due to how I incorrectly fixed the missing hook functions now that they are methods on classes.

    I need to call the actual hooks directly still. I'll update my local patch, that will take care of the majority of the issues.

  • Merge request !9982Resolve #3483599 "Conversion6" → (Open) created by nicxvan
  • 🇺🇸United States nicxvan

    nicxvan changed the visibility of the branch 3483599-conversion5 to hidden.

  • 🇺🇸United States nicxvan

    Ok missing functions should be all fixed now, I also have a bigpipe patch so that is no longer manual.

  • Pipeline finished with Failed
    1 day ago
    Total: 80s
    #323339
  • Pipeline finished with Failed
    1 day ago
    Total: 799s
    #323342
  • Merge request !9983Resolve #3483599 "Conversion7" → (Open) created by nicxvan
  • 🇺🇸United States nicxvan

    0003 has an update coming, but in order to not lose anything here are the patches used in conversion7

    Also 8 doesn't apply, but it's super easy to just fix the bigpipehooks arrays manually.

  • Pipeline finished with Failed
    1 day ago
    Total: 862s
    #323496
  • 🇺🇸United States nicxvan

    nicxvan changed the visibility of the branch 3483599-conversion6 to hidden.

  • Pipeline finished with Failed
    1 day ago
    Total: 89s
    #323540
  • Pipeline finished with Failed
    1 day ago
    Total: 608s
    #323544
  • 🇺🇸United States nicxvan

    nicxvan changed the visibility of the branch 3483599-conversion7 to hidden.

  • Merge request !9986Resolve #3483599 "Conversion8" → (Open) created by nicxvan
  • Pipeline finished with Failed
    1 day ago
    Total: 160s
    #323570
  • 🇺🇸United States nicxvan

    Patches are out of date.

  • Pipeline finished with Failed
    1 day ago
    Total: 730s
    #323576
  • Pipeline finished with Failed
    1 day ago
    Total: 282s
    #323587
  • Pipeline finished with Failed
    1 day ago
    Total: 855s
    #323595
  • Pipeline finished with Failed
    about 23 hours ago
    Total: 2592s
    #323636
  • Pipeline finished with Failed
    about 16 hours ago
    Total: 148s
    #323953
  • Pipeline finished with Failed
    about 16 hours ago
    Total: 156s
    #323963
  • Pipeline finished with Failed
    about 16 hours ago
    Total: 692s
    #323970
  • Merge request !9997Resolve #3483599 "Conversion9" → (Open) created by nicxvan
  • Pipeline finished with Failed
    about 11 hours ago
    Total: 602s
    #324210
  • Pipeline finished with Failed
    about 10 hours ago
    Total: 628s
    #324227
  • Pipeline finished with Running
    about 9 hours ago
    #324271
  • 🇺🇸United States nicxvan

    nicxvan changed the visibility of the branch 3483599-conversion8 to hidden.

  • Pipeline finished with Failed
    about 8 hours ago
    Total: 810s
    #324321
  • Pipeline finished with Failed
    about 7 hours ago
    Total: 741s
    #324371
  • Pipeline finished with Failed
    about 4 hours ago
    Total: 141s
    #324512
  • Pipeline finished with Failed
    about 2 hours ago
    Total: 7929s
    #324528
Production build 0.71.5 2024