Add void return type to all hook_entity_type_alter implementations

Open on Drupal.org →

Created on 29 October 2024, about 1 month ago

Problem/Motivation

See 📌 [META] Add return types to hook implementations Active

Steps to reproduce

Find all occurrences in the baseline:

grep "Function .*_entity_type_alter\\\\.* has no return type specified" core/.phpstan-baseline.php

Proposed resolution

Add : array to each of them.

This nifty command will find and replace all occurrences that come shortly after "Implements hook_entity_type_alter()":
find . -type f -exec sed -i '/Implements hook_entity_type_alter()/,/\(function .*_entity_type_alter(.*)\) *{/!b;/\(function .*_entity_type_alter(.*)\) *{/s/\(function .*_entity_type_alter(.*)\) *{/\1: void {/' {} +

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task

Status

Active

Version

11.0 🔥

Component

entity system

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!9990Add void return type to all hook_entity_type_alter implementations
Closed
🇦🇺Australia mstrelan
updated 20 days ago

Comments & Activities

Issue created by @mstrelan
Merge request !9990Issue #3484249: Add void return type to all hook_entity_type_alter implementations → (Closed) created by mstrelan
Comment about 1 month ago →
🇦🇺Australia mstrelan
Pipeline finished with Success
about 1 month ago
Total: 1625s
#323749
Comment 30 days ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Comment 28 days ago →
🇦🇺Australia mstrelan
Rebased and rebaselined
Pipeline finished with Success
28 days ago
Total: 804s
#329734
Comment 28 days ago →
🇺🇸United States smustgrave
Rebase seems good to me
Comment 21 days ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Comment 21 days ago →
🇦🇺Australia mstrelan
Re-rolled
Pipeline finished with Success
21 days ago
Total: 1404s
#336816
Comment 21 days ago →
🇺🇸United States smustgrave
Rebase seems good
Comment 20 days ago →
System Message

catch → committed 546aee1a on 11.1.x
Issue #3484249 by mstrelan: Add void return type to all...
Comment 20 days ago →
System Message

catch → committed 8e261bf9 on 11.x
Issue #3484249 by mstrelan: Add void return type to all...
Comment 20 days ago →
🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 11.1.x, thanks!
Comment 20 days ago →
System Message
catch → closed merge request !9990
Comment 6 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024