Warning when building an empty workspace tree

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

This will need a test case to show the issue.

Here's a test for this. Also, this would've been caught from the start if we had return types on the workspace repository methods, so adding them now while we're at it.

The last submitted patch, 11: 3154084-11-test-only.patch, failed testing. View results →

Thanks for the quick followup!

Test case proves the issue and the typehints are a welcomed addition.

LGTM.

The last submitted patch, 11: 3154084-11-test-only.patch, failed testing. View results →

+++ b/core/modules/workspaces/src/WorkspaceRepositoryInterface.php
@@ -17,7 +17,7 @@ interface WorkspaceRepositoryInterface {
    *   - descendants: The descendant IDs of the workspace.
    */
-  public function loadTree();
+  public function loadTree(): array;
 
   /**
    * Returns the descendant IDs of the passed-in workspace, including itself.
@@ -28,7 +28,7 @@ public function loadTree();

@@ -28,7 +28,7 @@ public function loadTree();
    * @return string[]
    *   An array of descendant workspace IDs, including the passed-in one.
    */
-  public function getDescendantsAndSelf($workspace_id);
+  public function getDescendantsAndSelf($workspace_id): array;
 

I don't think we can do this in a minor, it would break any code implementing the interface (as unlikely as that might be). See 🌱 [Meta] Implement strict typing in existing code Active . Needs splitting to its own issue I think.

That's ok, it wasn't the important part of the patch anyway :)

Thanks, no extra type hints also means I went ahead and cherry-picked this back to 10.0.x and 9.5.x too.

I don't see the commit to 10.0.x?

Cherry-picked back to 10.0.x, thanks for spotting that.

Automatically closed - issue fixed for 2 weeks with no activity.