- Issue created by @bnjmnm
- Status changed to Needs review
about 2 years ago 12:59pm 20 March 2023 - π«π·France duaelfr Montpellier, France
I believe that
role="img"
would allow that span to carry the label and avoid having to set it on the SVG that could be used in another context and would need another alt text.Used command
yarn test:nightwatch --tag a11y:default --defaultTheme olivero
Before
οΈ TEST FAILURE (7.952s): - 1 assertions failed; 96 passed β 1) Tests/a11yTestDefault β Accessibility - Default Theme: Homepage (909ms) β β NightwatchAssertError aXe rule: aria-allowed-attr - Elements must only use allowed ARIA attributes In element: .drupal-logo
After
β¨ PASSED. 99 total assertions (8.189s)
- Status changed to RTBC
about 2 years ago 6:56pm 20 March 2023 - πΊπΈUnited States smustgrave
With π Automated A11y tests in Nightwatch Fixed applied I confirmed the issue being reported (commented out the bypass)
Applied the patch here in #2 and it fixed the issue.
If π Automated A11y tests in Nightwatch Fixed lands first this should be updated to include removing those bypasses.
The race is on!
The last submitted patch, 2: 3349028-2.patch, failed testing. View results β
- π«π·France nod_ Lille
Committed 93f9149 and pushed to 10.1.x. Thanks!
Working on the backport to 9.5 and 10.0 since there is a conflict because of π Olivero: Remove svg from block--system-powered-by-block.html.twig file Fixed . Since this is an accessibility issue, I want to make sure we backport this one.
- Status changed to Fixed
about 2 years ago 1:32pm 2 April 2023 - π«π·France nod_ Lille
CI says "failed to apply" because The commit was pushed before the testbot started running so it tried to apply the patch on the "already fixed" version of the code.
- Status changed to Fixed
almost 2 years ago 10:54pm 17 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.