- ๐จ๐ญSwitzerland berdir Switzerland
Rerolled for 9.5 and later (hopefully), updating the tests to work again, looks like classes and also timezone handing changed.
Tests still pass without the fix, see #13/#14, but one option would be to get this committed, then we have test coverage once that issue lands?
- Status changed to RTBC
over 1 year ago 3:26pm 23 February 2023 - ๐ณ๐ฑNetherlands Lendude Amsterdam
+1 for just adding the coverage here to avoid the chicken/egg problem. The test might not prove the bug, but it does give more confidence that we aren't breaking anything.
+++ b/core/modules/views/tests/src/FunctionalJavascript/PaginationAJAXTest.php @@ -99,7 +99,7 @@ public function testBasicPagination() { // Test that no unwanted parameters are added to the URL. - $this->assertEquals('?status=All&type=All&langcode=All&items_per_page=5&order=changed&sort=asc&title=&page=2', $link->getAttribute('href')); + $this->assertEquals('?status=All&type=All&langcode=All&items_per_page=5&order=changed&sort=asc&page=2', $link->getAttribute('href'));
Sorta gave me pause, since this removes more unwanted parameters, so how come this wasn't removed before? Since it's empty, it looks ok, but still an unexpected side effect I think?
- First commit to issue fork.
- @kunal_sahu opened merge request.
- ๐ฎ๐ณIndia kunal_sahu Karnataka
Hi I have created a MR . Please Merge . Thanks
- ๐ณ๐ฟNew Zealand quietone
@kunal_sahu, I am removing credit per How is credit granted for Drupal core issues โ .
- ๐จ๐ญSwitzerland berdir Switzerland
> Sorta gave me pause, since this removes more unwanted parameters, so how come this wasn't removed before? Since it's empty, it looks ok, but still an unexpected side effect I think?
Yeah, looks like the different kinds of exposed input things handle empty parameters differently, I think that's an acceptable change and based on you setting it to RTBC, I assume you agree :)
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Committed and pushed a487817dbe to 10.1.x and 9041793c01 to 10.0.x. Committed 3664a3d and pushed to 9.5.x. Thanks!
-
alexpott โ
committed a487817d on 10.1.x
Issue #2865401 by Berdir, yassin.barrani, ankithashetty, dxvargas,...
-
alexpott โ
committed a487817d on 10.1.x
-
alexpott โ
committed 9041793c on 10.0.x
Issue #2865401 by Berdir, yassin.barrani, ankithashetty, dxvargas,...
-
alexpott โ
committed 9041793c on 10.0.x
- Status changed to Fixed
over 1 year ago 1:01am 24 February 2023 -
alexpott โ
committed 3664a3d4 on 9.5.x
Issue #2865401 by Berdir, yassin.barrani, ankithashetty, dxvargas,...
-
alexpott โ
committed 3664a3d4 on 9.5.x
- Status changed to RTBC
over 1 year ago 2:27am 24 February 2023 - ๐ต๐นPortugal dxvargas
The tests are now fixed in #32, good!
For the rest, it is the same fix as before (#25), that was already reviewed by the community.
Let's move back the issue to RTBC. - Status changed to Fixed
over 1 year ago 8:25am 24 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.