- Issue created by @catch
- Status changed to Needs review
over 1 year ago 4:30pm 31 March 2023 - ๐บ๐ธUnited States dww
Yes, please!
Do we need a follow-up to fix it and an @todo comment here so we do t forget to unskip it someday?
- Status changed to RTBC
over 1 year ago 5:07pm 31 March 2023 - ๐บ๐ธUnited States smustgrave
@dww think the referenced ticket ๐ [random test failure] Drupal\Tests\ckeditor5\FunctionalJavascript\MediaLibraryTest Active should be good?
Going ahead and marking it because "Waiting for branch to pass" means more random failures are on the way.
The last submitted patch, 2: 3351596.patch, failed testing. View results โ
- ๐บ๐ธUnited States dww
Hah, whoops. ๐ But at least #2 also randomly failed, so I don't feel so bad uploading yet another patch here. ๐ Now with passing
commit-code-check.sh
-
longwave โ
committed 60af95fd on 10.0.x
Issue #3351596 by dww, catch: Skip Drupal\Tests\ckeditor5\...
-
longwave โ
committed 60af95fd on 10.0.x
-
longwave โ
committed 56a7a8e2 on 10.1.x
Issue #3351596 by dww, catch: Skip Drupal\Tests\ckeditor5\...
-
longwave โ
committed 56a7a8e2 on 10.1.x
- Status changed to Fixed
over 1 year ago 7:05pm 31 March 2023 - ๐ฌ๐งUnited Kingdom longwave UK
Committed and pushed 56a7a8e28c to 10.1.x and 60af95fd8e to 10.0.x. Thanks!
I'll see you again over in ๐ [random test failure] Drupal\Tests\ckeditor5\FunctionalJavascript\MediaLibraryTest Active
- ๐ฌ๐งUnited Kingdom longwave UK
As discussed in Slack: the fails only seem to be affecting 10.1.x and 10.0.x, so I am holding off on backport so we can then use 9.5.x as a kind of canary - if the builds start failing there as well, either we really did break something, or it might give us the clue as to the root cause of all this.
- ๐บ๐ธUnited States xjm
This test does fail on 9.5.x and 9.4.x; I have emails for it going back to CKE5's addition to core, including for those branches. I have had it fail for security advisories' private test runs. There just aren't as many failures for it because there aren't as many commits to those branches.
Therefore, I will backport this to 9.5.x and 9.4.x as well.
-
xjm โ
committed 26f6f5d0 on 9.5.x authored by
longwave โ
Issue #3351596 by dww, catch: Skip Drupal\Tests\ckeditor5\...
-
xjm โ
committed 26f6f5d0 on 9.5.x authored by
longwave โ
-
xjm โ
committed 1b149043 on 9.4.x authored by
longwave โ
Issue #3351596 by dww, catch: Skip Drupal\Tests\ckeditor5\...
-
xjm โ
committed 1b149043 on 9.4.x authored by
longwave โ
- Status changed to Fixed
over 1 year ago 10:14pm 20 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.