- Issue created by @catch
- Status changed to Closed: duplicate
over 2 years ago 5:06pm 31 March 2023 - 🇬🇧United Kingdom catch
Not sure what happened there, dup of 📌 Skip Drupal\Tests\ckeditor5\FunctionalJavascript\MediaLibraryTest Fixed
- Status changed to Postponed
over 2 years ago 5:07pm 31 March 2023 - 🇬🇧United Kingdom catch
Wait no we need this one, it's the follow-up to the other one.
- Status changed to Active
over 2 years ago 7:16pm 31 March 2023 - 🇺🇸United States dww
The skip issue is now in, so no need for this one to be postponed.
Thanks,
-Derek - 🇮🇳India deepakkm
is there any update on this issue, as this is creating tests to fail frequently now.
- 🇬🇧United Kingdom catch
@deepakm MediaLibraryTest::testButton() is skipped so can't fail - this issue was opened to unskip it when it's reliable again, which has not happened yet. Which test is failing frequently now?
- 🇮🇳India deepakkm
MediaLibraryTest::testButton() - this tests fail when we uncomment the code for skipping the test, this has dependency on 1 of our custom phpunit tests written because we are also doing similar functionality to test insert media button on ckeditor5 editor.
- First commit to issue fork.
- Merge request !12999Issue #3351597: Unskip MediaLibraryTest::testButton → (Closed) created by acbramley
- 🇦🇺Australia acbramley
Had to remove the "item selected" assertions as that text no longer seems to exist in the CKE widget. Running the repeat test to see how many failures we get.
- 🇦🇺Australia acbramley
The test has passed 200/200 times. It's not clear from the previous issue where the failure was since the old CI jobs no longer exist so it's hard to tell if the random failure is indeed fixed
- 🇦🇺Australia acbramley
@smustgrave I don't see that text when using media library in CKE5, it probably got hidden at some point as that's more for fields with specific cardinality (it doesn't make sense when embedding media)
- 🇺🇸United States smustgrave
Oh you're right, odd but guess it makes sense since you can only grab 1 at a time in ckeditor.
- 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 11.2.x/10.6.x/10.5.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.