D10 Oliveros header is hidden by Gins secondary toolbar after scroll

Screenshot of proposed solution:

It's not perfect for the horizontal toolbar:

Add attribute data-offset-top only for the vertical toolbar layout.

I didn't test on Drupal 9, only Drupal 10.

Cannot reproduce on D9.

Relevant changes made in #3277809: Use Drupal.displace()'s new CSS variables to place Olivero's fixed header → , maybe #3291729: Refactor Olivero styles to use new --drupal-displace variables and ensure that toolbar/buttons are always visible → .

So Olivero D10 changed header positioning to use displace instead of fixed toolbar height values. Maybe worth a CR. But the Drupal toolbar had data-offset-top attribute before. Maybe gin_toolbar should have used it before.

FYI: Gin has a couple of CSS variables, which can be used by frontend themes to offset whatever is sticky in their own theme:

    --gin-toolbar-secondary-height
    --gin-icon-size-toolbar
    --gin-scroll-offset
    --gin-toolbar-y-offset
    --gin-toolbar-x-offset
    --gin-sticky-offset

I guess this is outdated as I couldn't reproduce it with Gin RC2.

I've checked with

1. Drupal 10
2. Gin 8.x-3.0-rc2
3. Gin Toolbar 8.x-1.0-rc1

Still reproduceable.

In Drupal 9 it's not a problem, only Drupal 10. Didn't check Drupal 10.1.x

Reproduced with Drupal 10.1.x-dev.

@hudri regarding #10: I think this is not about a custom theme. I would like gin_toolbar to play nice with Drupals default theme.

Olivero changed it's behavior in Drupal 10, see Slack message by @mherchel:

Is that Drupal 9 or 10? Within D10, Olivero uses the new custom CSS properties to place the header. Within D9, we only check for the CSS classes added by the toolbar

Corresponding integration in Gin -> 📌 Update Drupal.displace when vertical toolbar changes Fixed

Automatically closed - issue fixed for 2 weeks with no activity.