Add functionality for all-day events

Created on 1 June 2018, over 6 years ago
Updated 6 September 2024, 3 months ago

Currently, there is no proper functionality to support all-day events - although generally available in the fullcalendar plugin. Would be really great to have that functionality in the module as well.

✨ Feature request
Status

Needs work

Version

5.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany extect Germany

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¦πŸ‡ΊAustralia mingsong πŸ‡¦πŸ‡Ί

    I close it as 8.x branch is not supported anymore.

    Which means the new feature quested won't be consider anymore.

  • Status changed to Active over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States lpeabody

    Re-opened because the patch in #17 was re-rolled against the 5.x branch and the feature request is still valid (5.x doesn't support all-day functionality for a single day).

  • πŸ‡ΊπŸ‡ΈUnited States sacarney

    Is this feature request meant to address the undesired display of a time on All Day events? If the event is All Day, I don't want the time (12:00AM) to appear on the event in the calendar.

  • πŸ‡¨πŸ‡¦Canada chrisck BC, Canada

    While the original issue summary does not mention using smart_date for all day functionality, smart_date is mentioned quite a few times in the comments. I'm reporting that smart_date 4.0.2 is working out of the box with fullcalendar_view 5.1.12 with all day functionality, without requiring any patches.

    Perhaps what some are missing is that the field type has to be "Smart date range" and not, the core "Date range" with Smart date widget.

    Download and enable the Smart Date Calendar Kit β†’ on a new Drupal install and look at how it's configured.

  • πŸ‡¨πŸ‡¦Canada geekygnr Waterloo

    This patch causes warnings if the end date is not set.

  • πŸ‡¨πŸ‡¦Canada geekygnr Waterloo

    Here is a new patch. Adds some checks for empty values and addressed some phpcs issues.

  • πŸ‡ͺπŸ‡¨Ecuador LeonelEnriquez98

    I updated the patch that @geekygnr left in comment #25 to be compatible with the latest version 5.1.13

  • πŸ‡ΊπŸ‡ΈUnited States ferminaguilar

    @LeonelEnriquez98 The patched worked for the most part but its posting two days. So I post an event for 1 day 11/20 but when viewing it's showing all day for 11/19 and all day 11/20 for the same event. I just added the start date only and also did the say day for Start and End date and still the same issue.

  • πŸ‡ͺπŸ‡¨Ecuador LeonelEnriquez98

    @ferminaguilar I could reproduce that error. It was related to the timestamp variable. So here I leave the new patch.

  • @ferminaguilar @LeonelEnriquez98 I still had the same issue with all-day events starting on the day before they should after applying patch #28. I believe the issue is because when finding the start date, it applies the difference from UTC to a date which has already had the difference applied to it. So it applies the timezone difference twice. Here's a new patch.

  • πŸ‡ͺπŸ‡¨Ecuador LeonelEnriquez98

    @jennine Your patch seems to be working fine. Thanks!

  • πŸ‡ΊπŸ‡ΈUnited States xpersonas

    Patch #30 fixed the starting a day early for me... but now they are running a day over. I assume that's because my events are coming in with a start date of 00:00:00 day 1 to 00:00:00 day 2. Trying to figure out if I need to adjust the patch for my situation or if I have something configured wrong.

  • πŸ‡ΊπŸ‡ΈUnited States xpersonas
  • Status changed to Needs work 5 months ago
  • πŸ‡©πŸ‡ͺGermany luenemann SΓΌdbaden, Germany
    1. +++ b/src/FullcalendarViewPreprocess.php
      @@ -160,8 +160,8 @@ class FullcalendarViewPreprocess {
      -    $timezone = !empty($start_field_option['settings']['timezone']) ?
      -    $start_field_option['settings']['timezone'] : date_default_timezone_get();
      +    $timezone = !empty($start_field_option['settings']['timezone_override']) ?
      +    $start_field_option['settings']['timezone_override'] : date_default_timezone_get();
           // Set the first day setting.
      

      This reverts changes from πŸ› Entries always rendered with the field selected timezone Fixed . But that removes support for datetime and daterange formatters.
      timezone is a setting of timestamp formatter.
      This should be fixed in a separat issue to support both formatters.

    2. +++ b/src/FullcalendarViewPreprocess.php
      @@ -332,7 +332,7 @@ class FullcalendarViewPreprocess {
      -              elseif (strpos($end_field_option['type'], 'daterange') !== FALSE) {
      +              elseif (strpos($end_field_option['type'], 'daterange_default') !== FALSE) {
      

      This change removes support for daterange_plain and daterange_custom formatters. It should be reverted.

    Needs work for 2.

  • Pipeline finished with Success
    5 months ago
    Total: 170s
    #224561
  • First commit to issue fork.
  • πŸ‡ΊπŸ‡ΈUnited States mortona2k Seattle

    Rebased on 5.x and cleaned up a section with different checks on $options.

  • Pipeline finished with Success
    3 months ago
    Total: 174s
    #276147
Production build 0.71.5 2024