🇺🇸United States @xpersonas

@anybody, do you not want me contributing to this module? I'm not getting the Drupal community love vibes here. Lol

Regarding that schema change. I agree. Sadly, that schema change did not make sense to me either. That's why I worked to revert that change already.

https://git.drupalcode.org/project/protected_forms/-/merge_requests/8/diffs

That change to the schema was added to the this MR at some point, but didn't really make sense to me.

https://git.drupalcode.org/project/protected_forms/-/merge_requests/8/di...

That's why I reverted it. There were quite a few changes, some that made sense, some that did not, and some that were going in a good direction. Which is why I consolidated all that into the current state of the MR.

I would ask that you review the current state of this MR vs only looking at the commit history.

If this MR stands no chance of ever being approved, that's ok too. Not a big deal. Just let me know so I can take the appropriate action with all my client sites.

@tirupati_singh: Thank you for testing things out so thoroughly and adding a video. I see the issue now. I pushed up a fix. If you try to run a new patch with the current diff, that error should go away. At least it did for me. So let me know if you have any issue with it.

Apologies. I did fix the constructor error. After another fight with phpstan, I have the changes committed with all tests passing to Drupal standards. Green checks everywhere. Though certainly more tests could be added (and welcomed).

But again. Apologies if I have taken this in the wrong direction, that was not my intention. I was only hoping to help and contribute because that is the "Drupal" thing to do.

For me, pattern matching within strings was never going to be a solution to any problem I had. For all my sites, and I presumed others, it needed to check whole word instances. However, I've felt a bit of push back on this the entire time. I did like how this module was set up overall, so it just made sense to add that feature to it while keeping your initial string check. Which is what I tried to do. I wanted to contribute.

My last merge request was an attempt to:
- maintain whole word instance checking as an option
- add cli tests for eslint, phpcs, and phpstan
- add/refine phpunit tests based on what existed, what was suggested, and what I thought was logical
- log rejections in it's own table rather than watchdog (which could perhaps be a setting) because on high traffic sites, I was often asked what was rejected only to find it was too late

Looks like the MR reverts previous expected changes. Instead it should fix the issues without reverting the improvements. Especially I don't like the schema to be reverted.

My intention was not to revert any improvements. I tried to carry over most of the previous commits. If "improvements" were reverted, I'm open to discuss.

It's been a few months, but I believe my changes to the schema were to address code quality and test issues that arose. I certainly wouldn't change the schema for a fun time. I have this MR running on many high profile, high traffic sites. I saw no issues with my changes on those sites and in my tests. Please let me know if they caused any other issues though.

I have this module in a really good place for my needs, and I realize that's "my" needs. This issue/thread began what is going on 3 years now. Perhaps I should take this version of the module I have now and make it a private custom module from this point forward. I'm honestly not trying to step on any toes or cause any issues for anyone. So again, apologies if it feels that way.

Hello. I did some cleanup on this fork. Took a lot of the previous commits, but also got cli tests passing for eslint, phpcs, and took some of the phpunit tests we had and cleaned that up so that we have some basic functionality, login, and install/uninstall tests. Even though I had a fight with phpstan, I think it's in a decent spot.

I had a few site accidentally updated to the release version of this module. My clients had included "spac" as a reject pattern. (Not really sure why or what that means, but they added it) And I had a lot of forms rejected for using the word "spacing". I've found this module tremendously helpful, but it's hard for me to imagine using it without the option to check whole words.

There must be use cases for checking within strings instead of whole words, but I haven't encountered that in my experience.

This fork also logs rejections to it's own table rather than the main watchdog table. (that was added a while back) I've had way too many instances where I have a rejected form submission but it was already removed from the watchdog list.

So whole word checking and logging to a separate table are essential to my workflow. I'd love to see this become part of the primary module if possible. And I'm happy to help in any way I can. Let me know if anyone has any thoughts or problems.

Thanks for the idea here. I updated the test to have some assertions. Seems to be working well. It's in the dev version now if you want to take a look. Let me know if you have any concerns.

Thank you for this. I hadn't fully got into the Gitlab workflow. I took the base template you had and customized it further. Let me know if you see any issues!

Thank you ptmkenny. I did a little restructuring and took these eslint errors into account. If you wouldn't mind checking out the latest dev release when you have time, that would be great.

Thanks guys. I updated the tests a bit and took these coding standards into account. If you don't mind trying the new dev release to see if you have issues, that would be great. Right now everything is passing in phpcs for me.

I can confirm this issue as well. I'm also curious if you guys have this issue?
https://www.drupal.org/project/select_or_other/issues/3463820 🐛 Missing "None" Option on Checkbox/Radio Display Active

xpersonas → created an issue.

Hello apaderno and ptmkenny,

I appreciate the offer. At this time I would like to continue to be the sole maintainer. It's been a bit of a year for me, but I am trying to get everything caught up again. I have begun cleaning up the issue queue and prepped for D11. I released version 2.0.1 today with many of those changes.

I'm going to continue to work through the remaining items regarding the Gitlab CI template and others. I definitely appreciate the help with merge requests and/or patches. This is one of the few modules I have written that I use on every site and rather enjoy. Therefore, at this time, I would like to keep it under my wing. At least until a later time when I may not be able to keep up.

Thank you again

Apologies. The generated form content was missing.
This should be fixed in the latest dev version.

xpersonas → created an issue.

Patch #30 fixed the starting a day early for me... but now they are running a day over. I assume that's because my events are coming in with a start date of 00:00:00 day 1 to 00:00:00 day 2. Trying to figure out if I need to adjust the patch for my situation or if I have something configured wrong.

xpersonas → created an issue.

I ran into this issue trying to access a company calendar that had restricted permission to see only "free/busy", not "see all event details."

Not sure if that's helpful, but wanted to note it since I found this issue troubleshooting the same thing.

This would be extremely useful. I was hoping these events already existed, but I guess they do not. I'm currently debating how to handle a slider. Without an event, I may just have to add the text "Please save this page to see updated component." which isn't the bet UX for the admin.

Thank you

I'm struggling to install this on a new D10 site. I managed to updated a site from D9 to D10 with patches. But seem to be struggling on a new install.

xpersonas → created an issue. See original summary → .

+1 on #DrupalWTF. I can't believe I'm encountering this problem with Drupal 10 in 2023, even if it is a minor issue overall. I either have to hack some code to remove it or tell my clients "just ignore that" because it's an immovable object - no one knows how or why it exists but we know you can't change anything about it!

I would love to see this module be compatible with D10. I can confirm the patches are working for me on my D10 sites. I wish I was better educated at fixing tests. That's one area I still struggle with.

Agreed. Would love to see this module updated for my D10 sites.

Updating in dev and 2.0.x versions.

Is this still an issue? I'm having trouble reproducing it now. Maybe I'm not understanding how the view is set up. Happy to look at it with more specific steps to reproduce.

Closing this issue. If more people have a request for this, I would be happy to review a merge request.

As this issue is over 4 years old, is this still causing issues?

Code has been updated in dev and 2.0.x versions.

I'm sorry. At this time, there is no plan to add commerce entities. Though I would welcome a merge request.

The dev version (8.x-1.x-dev) and 2.0.x versions have been updated for D8/D9/D10 compatibility. Let's create a new issue if needed since this one is years old.

The dev version (8.x-1.x-dev) and 2.0.x are compatible with D9 now.

The development version (8.x-1.x-dev) and the 2.0.x versions should be ok to use now.

Thank you for the MR. Your changes are in the dev version 8.x-1.x-dev and the 2.0.x branch.

Updated development version: 8.x-1.x-dev.

I believe this issue has been resolved with merge requests on issue #3072720.
https://www.drupal.org/project/nodeorder/issues/3072720#comment-14981147 📌 Drupal 9 Deprecated Code Report for Node Order Needs review

Drupal 9 Compatible: 8.x-1.x-dev
Drupal 10 Compatible: 2.0.0

If something necessary was missed, please let me know.

Yes, thank you @dieuwe. Will do.

Dev version has been updated and should be compatible with Drupal 9 now.

Good catch. Thanks for the patch.

Thanks @gisle. Sorry. First time trying this process. I apologize for fumbling through it.

Thanks @ReneW. I appreciate that. Yeah just trying to do this the right way. I made a new issue asking to be a maintainer or co-maintainer. I think I have to wait 2 weeks before I can request ownership through drupal.org. So that's what I'm going to try.

xpersonas → created an issue.

LOL. Well, I'm failing. I guess I misunderstood the instructions. I jumped straight to #6. Trying to be helpful, but I think I'm doing the opposite. Apologies to everyone.

https://www.drupal.org/project/nodeorder →

I would be happy to become a maintainer for this project. But I don't feel like the maintainers are responding. If there's a way to do that for an abandoned project, I'm not aware of it. The original authors and maintainers did a great job with this module. I just need something stable going forward. I can remove my project or keep it private if it causes conflict or this module gets updated.

Ok, I find this module absolutely necessary on quite a few sites. It was hard enough with Drupal 9, but now that I'm updating to Drupal 10...

I went ahead and created a new module. I'm going to use it to cater to Drupal 9 and 10 only. It's mostly an updated copy of this module's current state (right now), updated to work with Drupal 10 and renamed as to not cause conflicts.

https://www.drupal.org/project/node_order_by_term →

Feel free to open up issues, request to co-maintain, etc.. Or maybe I just use it. Either way. I just need this module working on my Drupal 10 upgrade, and I feel like this is going to be the easiest route.

Agreed. Added a note on the description. I will continue to maintain this module for the few sites using it.

Valid point. Updated.

Sorry for the delay. I have applied the MR and released it as a 2.0.x version. Let me know if you have any issues!

Is it safe to say this module is no longer maintained? There's no D8 version on the release page. The last D8 beta was created on May 2, 2018.

I find this module immensely useful and use it on my most of my larger sites even to this day.

I'm curious what we do now? I'd like to see this module kept up to date. What would be best? Do we just use the fork forever? Can we become maintainers somehow? Just want to see this module continue. I don't think there's a viable alternative, and I don't want to pollute the module list with a clone of this module with a different name.

What do we do?

Never mind. It was my css.

xpersonas → created an issue. See original summary → .