Fix coding standards

Hi

I applied the MR !6 and it says in my terminal composer.json file not found

➜  simple_styleguide git:(2.0.x) curl https://git.drupalcode.org/project/simple_styleguide/-/merge_requests/6.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1619    0  1619    0     0   3150      0 --:--:-- --:--:-- --:--:--  3199
Checking patch composer.json...
error: composer.json: No such file or directory
Checking patch src/Controller/DefaultController.php...
Checking patch src/Form/StyleguideSettings.php...
➜  simple_styleguide git:(2.0.x) 

@clarkssquared Whoops, the merge targeted the wrong branch. Fixed, thank you.

Hi

I reviewed MR!6, applied against Simple Style Guide 2.0x-dev, confirmed patch applied cleanly however there are still remaining phpcs issue shown below:

jetherparadero@PrometSources-MacBook-Pro-3 contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig simple_styleguide

FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/simple_styleguide/src/Tests/StyleguidePageTest.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
 20 | ERROR   | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations.
 70 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
---------------------------------------------------------------------------------------------------------------------------------------------------

Time: 215ms; Memory: 10MB

jetherparadero@PrometSources-MacBook-Pro-3 contrib %

Please check and advise.
Thank you.

@paraderojether As stated in the issue summary, I fixed the coding standards issues pointed out by the GitLab CI template: https://git.drupalcode.org/issue/simple_styleguide-3442149/-/jobs/1379375. I wonder why you are getting different results than the CI scan.

xpersonas → closed merge request !6

Thanks guys. I updated the tests a bit and took these coding standards into account. If you don't mind trying the new dev release to see if you have issues, that would be great. Right now everything is passing in phpcs for me.

They are passing in CI, so that's good enough for me.

GitLab CI does a phpcs that is slightly different than the default one (it ignores phpstan errors to avoid duplicating work found in the phpstan scan). But since all tests are passing, it doesn't matter in this case.