Image strategies are never used. Regression in #3074285 The offline page is not displayed

@@ -377,6 +379,10 @@ self.addEventListener('fetch', function (event) { if (isCacheableAsset(url)) { event.respondWith(makeRequest.staleWhileRevalidate(event.request)); } + else if (!isCacheableAsset(url)) { + //this networkWithCacheFallback dont work with excluded path. + event.respondWith(makeRequest.networkWithCacheFallback(event.request)); + } // Check for save-data Header and avoid caching when present. else if (isImageUrl(url)) {

Comments & Activities

Issue created by @luenemann
Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update almost 2 years ago
Not currently mergeable.
@luenemann opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update almost 2 years ago
1 pass
Status changed to Needs review almost 2 years ago2:54pm 9 June 2023
Comment almost 2 years ago →
🇩🇪Germany luenemann Südbaden, Germany
It seems to work but did no extensive testing.
Status changed to RTBC over 1 year ago9:40am 10 August 2023
Comment over 1 year ago →
🇩🇪Germany Anybody Porta Westfalica
Thanks @luenemann - makes sense to me!
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
1 pass
Comment over 1 year ago →
System Message

Anybody → committed edfa4d91 on 2.x authored by luenemann →
Issue #3365903 by luenemann, Anybody: Image strategies are never used....
Status changed to Fixed over 1 year ago9:41am 10 August 2023
Comment over 1 year ago →
🇩🇪Germany Anybody Porta Westfalica
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Image strategies are never used. Regression in #3074285 The offline page is not displayed

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities