[a11y] Toolbar icons not visible in forced colors / high contrast mode

MR addresses this with some media queries for forced colors.

Hi, @bnjmnm As, I was reviewing this issue, this issue is not reproducible on my local environment. Can you please provide Steps to reproduce this issue?

Can you please provide Steps to reproduce this issue

Emulate forced colors mode in a browser (Chrome does this pretty easily) and notice the icons are not there.

Hi @bnjmnm Thanks for sharing the detail. I've tested that MR !269 and it's looking good. So, Moving it to RTBC. Attaching the before and after screenshot after applying the MR.

Testing Steps to Emulate forced color mode in a browser :

1. Go to Dev tool.
2. Press CMD+Shift+P (for mac) and CTRL+Shift+P (for windows).
3. Type "Rendering" in Run command.
4. Change dropdown "Emulate CSS media feature forced-colors" dropdown from "No emulation" to "Forced-colors: active".

Hi, I was working on forced colors/High contrast mode on Gin theme and found few issues related to missing icon on overall site. So, currently working on these fixes. Here's few screenshots as example.

Hi, I was working on forced colors/High contrast mode on Gin theme and found few issues related to missing icon on overall site. So, currently working on these fixes. Here's few screenshots as example.

That is counterproductive. The issue is not "fix all missing icons in forced colors", this is intentionally scoped to the Toolbar and should stay that way. Keeping issue scope a manageable size makes it easier to add incremental improvements that don't take hours to review. If you find additional icons missing that aren't in the toolbar, create new issues for those (once you've confirmed there aren't existing issues already covering them)

hi @bnjmnm As we are only covering the toolbar icon in this issue. we somehow missed "back to site" icon in gin's secondary toolbar. So, I have created a patch included your MR changes as well to fix that, As I'm struggling with creating an MR as don't have the access rights to push the code. Attaching an image after applying your MR and image after applying my patch.

@Moni_10
If you want access to push the code, you should be able to get that by clicking "Get push access"

I assume you're hoping to improve Gin here, but unfortunately your specific actions are more disruptive than helpful. Creating new issues for what you discovered, as mentioned in #7, would be helpful for the Gin project than trying to wedge them into this issue's scope.

In your patch there are changes to breadcrumbs and possibly other things unrelated to toolbar in that patch. The amount of work it takes just to compare the MR and patch and distinguish what is worth transferring kind of outweighs any benefits. Applying the patch on top of the issue fork would also have conflicts. A diff would have been more helpful if you wanted to supplement the existing changes.

The "back to site" icon is in the breadcrumb region, which is next to the toolbar, but not part of the toolbar. That's a great find and certainly merits an issue being created for it.

The MR itself still needs review, anything spotted in comments thus far has been out of scope of this issue's requirements.

Hi @bnjmnm Thanks for letting me know. Also, Changes that you can see in the file comes after formatting the document. If you actually compare the file code with the older one there's only formatting related issue(spacing) being fixed. So, That's the reason you can see this conflict between both file. There's only backtosite style been added from my end.

Hi, @saschaeggi, As per @bnjmnm comment above, Can we create a separate issue for this icon?

Also, Changes that you can see in the file comes after formatting the document. If you actually compare the file code with the older one there's only formatting related issue(spacing) being fixed

If I actually compare the file code I see that your patch adds breadcrumb styles that are out of scope.

Hi, @saschaeggi, As per @bnjmnm comment above, Can we create a separate issue for this icon?

There's no need to add to a maintainers workload to make this happen. You can just create the issue yourself.

** MR is still ready for review **

@bnjmnm This style was for back_to_site icon, but as you say we can ignore that as I'm creating new issue for this. Also, I'd Added @saschaeggi, because I already confirmed same with him before mentioning these above icon related issues.
So, we following as per the issue summary, then we're good to move into RTBC.
Thanks.

Hey @bnjmnm. I accidentally clicked on create an MR, unable close it as there's no option available for me to close an MR. Please ignore it.

Hi, I applied MR 269 in local after applied the changes are reflected and resolved Toolbar icons not visible in forced colors / high contrast mode
This issue.

Shared local screen shorts for reference.

Thanks!

Thanks @bnjmnm for this fix & @djsagar for reviewing 👏

Automatically closed - issue fixed for 2 weeks with no activity.