- Issue created by @mnk-0210
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
4 months ago Waiting for branch to pass - 🇮🇳India siddharthjain_7998
The above patch applies smoothly and the dependencies has been updated as per this article: https://www.drupal.org/docs/upgrading-drupal/upgrading-from-drupal-8-or-... →
- Status changed to Needs review
3 months ago 10:28am 10 April 2024 - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
3 months ago Waiting for branch to pass - First commit to issue fork.
-
shelane →
committed 6aa46032 on 8.x-3.x authored by
mnk-0210 →
Issue #3427365 by mnk-0210: Remove jQuery UI Library's Core dependency...
-
shelane →
committed 6aa46032 on 8.x-3.x authored by
mnk-0210 →
- Status changed to Fixed
6 days ago 6:23pm 21 June 2024 - Status changed to Needs work
6 days ago 11:13am 22 June 2024 - 🇵🇹Portugal jcnventura
I think this may need a 2nd commit. This change only moved the libraries from core to the contrib modules, but it doesn't enable the modules. Which means that the newly added libraries are not enabled now, but the theme depends on them.
This may need the following changes:
* Make the theme depend on these modules in bootstrap.info.yml (see [#2937955])
* Create a hook_update_n() to enable these modules during install
* Also add the missing libraries from the jquery_ui module (see https://git.drupalcode.org/project/jquery_ui/-/blob/8.x-1.x/jquery_ui.li...):
** jquery_ui/widget
** jquery_ui/mouse
** jquery_ui/position - 🇺🇸United States shelane
@jcnventura, yes, you're right. I've added the dependencies to the info file and added an update hook to enable the modules. I'm not sure what to do about the missing jquery libraries that you mentioned though.
- 🇵🇹Portugal jcnventura
They were declared before in bootstrap.libraries.yml and were removed when the MR was merged. They should be able to be trivially added back, as they are now all provided by the (non-core) jquery_ui module.